Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Username Recovery multichannel support configs #865

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Malith-19
Copy link
Contributor

@Malith-19 Malith-19 commented Oct 18, 2024

Proposed changes in this pull request

[List all changes you want to add here. If you fixed an issue, please
add a reference to that issue as well.]

  • Add separate configs for the email and sms channel in username recovery.

Related issues

Important notes

  • We are not removing the previous username enable config which is used to disable the connector when both email and sms channels are disabled.
  • To keep the backward compatibility we are using default value of the email channel as username enable value.

Related PRs

@@ -615,6 +615,8 @@ public static class ConnectorConfig {
public static final String FORCE_ADD_PW_RECOVERY_QUESTION = "Recovery.Question.Password.Forced.Enable";
public static final String FORCE_MIN_NO_QUESTION_ANSWERED = "Recovery.Question.MinQuestionsToAnswer";
public static final String USERNAME_RECOVERY_ENABLE = "Recovery.Notification.Username.Enable";
public static final String USERNAME_RECOVERY_EMAIL_ENABLE = "Recovery.Notification.Username.Email.Enable";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to send recovery notifications simultaneously via both email and SMS channels?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

admins can enable both channels but when we come to the flow user should select a one channel if both were enable and if only one channel available, then notification will be send to that channel directly.

@PasinduYeshan
Copy link
Contributor

Update unit tests for this class.

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 73.68421% with 5 lines in your changes missing coverage. Please review.

Project coverage is 36.46%. Comparing base (1929c98) to head (fd94896).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
...dentity/recovery/connector/RecoveryConfigImpl.java 73.68% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #865      +/-   ##
============================================
+ Coverage     36.04%   36.46%   +0.42%     
- Complexity     1450     1451       +1     
============================================
  Files           267      267              
  Lines         15788    15809      +21     
  Branches       2181     2184       +3     
============================================
+ Hits           5691     5765      +74     
+ Misses         9383     9327      -56     
- Partials        714      717       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants