-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Username Recovery multichannel support configs #865
base: master
Are you sure you want to change the base?
Add Username Recovery multichannel support configs #865
Conversation
@@ -615,6 +615,8 @@ public static class ConnectorConfig { | |||
public static final String FORCE_ADD_PW_RECOVERY_QUESTION = "Recovery.Question.Password.Forced.Enable"; | |||
public static final String FORCE_MIN_NO_QUESTION_ANSWERED = "Recovery.Question.MinQuestionsToAnswer"; | |||
public static final String USERNAME_RECOVERY_ENABLE = "Recovery.Notification.Username.Enable"; | |||
public static final String USERNAME_RECOVERY_EMAIL_ENABLE = "Recovery.Notification.Username.Email.Enable"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to send recovery notifications simultaneously via both email and SMS channels?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
admins can enable both channels but when we come to the flow user should select a one channel if both were enable and if only one channel available, then notification will be send to that channel directly.
Update unit tests for this class. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #865 +/- ##
============================================
+ Coverage 36.04% 36.46% +0.42%
- Complexity 1450 1451 +1
============================================
Files 267 267
Lines 15788 15809 +21
Branches 2181 2184 +3
============================================
+ Hits 5691 5765 +74
+ Misses 9383 9327 -56
- Partials 714 717 +3 ☔ View full report in Codecov by Sentry. |
Proposed changes in this pull request
[List all changes you want to add here. If you fixed an issue, please
add a reference to that issue as well.]
Related issues
Important notes
Related PRs