Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add governance config to enable/disable multiple emails and mobiles per user feature #866

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

PasinduYeshan
Copy link
Contributor

Proposed changes in this pull request

Introduced a governance configuration to enable or disable the "multiple emails and mobile numbers per user" feature.

This feature is not fully onboarded yet. The original plan was to implement an identity configuration that would apply server-wide and enable this functionality by default. However, the new attributes required for this feature are not supported by default in LDAP user stores. As a result, enabling it globally is not feasible at this time. By providing a governance configuration, administrators can choose to enable this feature if desired. For LDAP user stores, the administrator must manually configure the necessary attributes in the LDAP settings to support multiple emails and mobile numbers per user.

Related Issues

Related PRs

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 92.85714% with 2 lines in your changes missing coverage. Please review.

Project coverage is 36.12%. Comparing base (2536b16) to head (fac8701).
Report is 97 commits behind head on master.

Files with missing lines Patch % Lines
.../recovery/connector/UserClaimUpdateConfigImpl.java 85.71% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #866      +/-   ##
============================================
+ Coverage     36.04%   36.12%   +0.08%     
- Complexity     1450     1451       +1     
============================================
  Files           267      267              
  Lines         15790    15811      +21     
  Branches       2182     2184       +2     
============================================
+ Hits           5691     5712      +21     
+ Misses         9384     9383       -1     
- Partials        715      716       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/11403151366

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/11403151366
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/11403151366

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants