Add unit tests for doPreUpdateApplication method

[ShanChathusanda93]

Purpose

• $subject

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.69%. Comparing base (9146bd1) to head (fc77363).
Report is 8 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main     #498      +/-   ##
============================================
+ Coverage     57.58%   57.69%   +0.10%     
- Complexity     1740     1759      +19     
============================================
  Files           177      177              
  Lines          9688     9748      +60     
  Branches       1357     1378      +21     
============================================
+ Hits           5579     5624      +45     
- Misses         3642     3653      +11     
- Partials        467      471       +4     

Flag	Coverage Δ
unit	38.62% <ø> (+0.67%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Copilot]

Pull Request Overview

This pull request adds new unit tests for the doPreUpdateApplication method to ensure its correct behavior for different audiences and associated roles scenarios.

• Added a new data provider for testing associated roles.
• Introduced tests for both organization and application audiences.
• Verified the updates to thread-local properties after processing the update.

Comments suppressed due to low confidence (1)

components/org.wso2.carbon.identity.organization.management.handler/src/test/java/org/wso2/carbon/identity/organization/management/handler/listener/SharedRoleMgtListenerTest.java:358

• [nitpick] Consider using the constant ORGANIZATION_AUD instead of the literal string "ORGANIZATION" to maintain consistency across the test code.

associatedRolesConfig.setAllowedAudience("ORGANIZATION");

[Copilot]

Pull Request Overview

This PR introduces new unit tests for the doPreUpdateApplication method to validate role audience updates.

• Added a new data provider for testing associated roles scenarios.
• Introduced two new unit test methods to cover both organization and application audience scenarios.

Comments suppressed due to low confidence (1)

components/org.wso2.carbon.identity.organization.management.handler/src/test/java/org/wso2/carbon/identity/organization/management/handler/listener/SharedRoleMgtListenerTest.java:241

• [nitpick] Consider renaming 'associatedRolesConfig02' to a more descriptive name like 'orgAudienceRolesConfig' to improve code clarity.

AssociatedRolesConfig associatedRolesConfig02 = new AssociatedRolesConfig();

[Copilot]

Pull Request Overview

This PR adds unit tests for the doPreUpdateApplication method to validate role audience updates related to organization and application audiences.

• Introduces new test cases including tests for organization audience and associated roles.
• Adds a data provider for scenarios involving different role audiences.

Comments suppressed due to low confidence (1)

components/org.wso2.carbon.identity.organization.management.handler/src/test/java/org/wso2/carbon/identity/organization/management/handler/listener/SharedRoleMgtListenerTest.java:226

• [nitpick] Consider renaming the data provider method to a shorter, clearer name (e.g., 'updateAppRolesDataProvider') to improve code readability.

@DataProvider(name = "testDoPreUpdateAppWithAssociatedRolesDataProvider")

[Copilot]

Pull Request Overview

This pull request introduces additional unit tests to validate the behavior of the doPreUpdateApplication method.

• Added new test cases and a data provider to cover scenarios with associated roles and different audience types.
• Introduced new constants and necessary imports to support the unit tests.

Comments suppressed due to low confidence (2)

components/org.wso2.carbon.identity.organization.management.handler/src/test/java/org/wso2/carbon/identity/organization/management/handler/listener/SharedRoleMgtListenerTest.java:408

• Consider clearing or isolating IdentityUtil.threadLocalProperties before and after tests to ensure test isolation and prevent interference between test cases.

Object finalUpdatedAssociatedRolesList = IdentityUtil.threadLocalProperties.get().get(ADDED_ORGANIZATION_AUDIENCE_ROLES);

components/org.wso2.carbon.identity.organization.management.handler/src/test/java/org/wso2/carbon/identity/organization/management/handler/listener/SharedRoleMgtListenerTest.java:243

• [nitpick] If the test scenario expects roles to be present in the organization audience configuration, consider initializing the roles array in orgAudienceAssociatedRolesConfig for clarity and consistency.

updatedOrgAudienceServiceProvider.setAssociatedRolesConfig(orgAudienceAssociatedRolesConfig);