Skip to content

Add Historical Range display in View Monitor page #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
rasika2012 wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add Historical Range display in View Monitor page #490

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
65 changes: 45 additions & 20 deletions console/workspaces/pages/eval/src/ViewMonitor.Component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
import React, { useMemo } from "react";
import { PageLayout } from "@agent-management-platform/views";
import {
Chip,
CircularProgress,
Grid,
IconButton,
Expand Down Expand Up @@ -101,6 +102,7 @@ export const ViewMonitorComponent: React.FC = () => {
"Selected period",
[timeRange],
);

const commonParams = useMemo(
() => ({
monitorName: monitorId ?? "",
Expand Down Expand Up @@ -135,6 +137,21 @@ export const ViewMonitorComponent: React.FC = () => {
const isLoading = isMonitorLoading || isScoresMainLoading;
const isRefetching = isMonitorRefetching || isScoresMainRefetching;

const isHistorical = monitorData?.type === "past";

const historicalRangeLabel = useMemo(() => {
if (!isHistorical) return null;
const fmt = (iso?: string) =>
iso
? new Date(iso).toLocaleDateString(undefined, {
year: "numeric",
month: "short",
day: "numeric",
})
: "—";
return `${fmt(monitorData?.traceStart)} – ${fmt(monitorData?.traceEnd)}`;
}, [isHistorical, monitorData?.traceStart, monitorData?.traceEnd]);

// ── raw evaluator arrays ─────────────────────────────────────────────────
const evaluators = useMemo(() => scoresMain?.evaluators ?? [], [scoresMain]);

Expand Down Expand Up @@ -323,26 +340,34 @@ export const ViewMonitorComponent: React.FC = () => {
)}
actions={
<Stack direction="row" spacing={1} alignItems="center">
<Select
size="small"
variant="outlined"
value={timeRange}
onChange={(e) =>
handleTimeRangeChange(e.target.value as TraceListTimeRange)
}
startAdornment={
<InputAdornment position="start">
<Clock size={16} />
</InputAdornment>
}
sx={{ minWidth: 140 }}
>
{MONITOR_TIME_RANGE_OPTIONS.map((opt) => (
<MenuItem key={opt.value} value={opt.value}>
{opt.label}
</MenuItem>
))}
</Select>
{isHistorical ? (
<Chip
icon={<Clock size={14} />}
label={historicalRangeLabel}
variant="outlined"
/>
) : (
<Select
size="small"
variant="outlined"
value={timeRange}
onChange={(e) =>
handleTimeRangeChange(e.target.value as TraceListTimeRange)
}
startAdornment={
<InputAdornment position="start">
<Clock size={16} />
</InputAdornment>
}
sx={{ minWidth: 140 }}
>
{MONITOR_TIME_RANGE_OPTIONS.map((opt) => (
<MenuItem key={opt.value} value={opt.value}>
{opt.label}
</MenuItem>
))}
</Select>
)}
<IconButton
size="small"
onClick={handleRefresh}
Expand Down