Fix evaluation monitors not creation and data publishing error

[menakaj]

Purpose

Describe the problems, issues, or needs driving this feature/fix and include links to related issues in the following format: Resolves issue1, issue2, etc.

This pull request introduces minor but important configuration updates to the Helm chart templates for the AMP Evaluation Extension. The changes focus on improving deployment behavior and clarifying configuration values.

Helm chart deployment improvements:

• Added Helm hook annotations (helm.sh/hook and helm.sh/hook-weight) to the ClusterWorkflowTemplate in cluster-workflow-monitor-evaluation.yaml to ensure the resource is created post-install and post-upgrade, and to control the order of hook execution.

Configuration and defaults updates:

• Changed the default namespace assignment in workflow-monitor-evaluation.yaml to use "default" if ampEvaluation.workflowNamespace is not set, rather than the Helm release namespace.
• Updated the default value of ampEvaluation.apiKey in values.yaml to "amp-internal-publisher-api-key" for clarity and consistency with its intended use.

Goals

Describe the solutions that this feature/fix will introduce to resolve the problems described above

Approach

Describe how you are implementing the solutions. Include an animated GIF or screenshot if the change affects the UI (email documentation@wso2.com to review all UI text). Include a link to a Markdown file or Google doc if the feature write-up is too long to paste here.

User stories

Summary of user stories addressed by this change>

Release note

Brief description of the new feature or bug fix as it will appear in the release notes

Documentation

Link(s) to product documentation that addresses the changes of this PR. If no doc impact, enter �N/A� plus brief explanation of why there�s no doc impact

Training

Link to the PR for changes to the training content in https://github.com/wso2/WSO2-Training, if applicable

Certification

Type �Sent� when you have provided new/updated certification questions, plus four answers for each question (correct answer highlighted in bold), based on this change. Certification questions/answers should be sent to certification@wso2.com and NOT pasted in this PR. If there is no impact on certification exams, type �N/A� and explain why.

Marketing

Link to drafts of marketing content that will describe and promote this feature, including product page changes, technical articles, blog posts, videos, etc., if applicable

Automation tests

• Unit tests

  Code coverage information

• Integration tests

  Details about the test cases and coverage

Security checks

• Followed secure coding standards in http://wso2.com/technical-reports/wso2-secure-engineering-guidelines? yes/no
• Ran FindSecurityBugs plugin and verified report? yes/no
• Confirmed that this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets? yes/no

Samples

Provide high-level details about the samples related to this feature

Related PRs

List any other related PRs

Migrations (if applicable)

Describe migration steps and platforms on which migration has been tested

Test environment

List all JDK versions, operating systems, databases, and browser/versions on which this feature/fix was tested

Learning

Describe the research phase and any blog posts, patterns, libraries, or add-ons you used to solve the problem.

Summary by CodeRabbit

• Chores
  • Optimized Helm deployment configurations for workflow templates with improved post-installation and upgrade handling procedures to enhance reliability.
  • Refined workflow namespace configuration defaults to ensure better deployment consistency across different environments and deployments.
  • Updated publisher service authentication credentials in configuration to align with current system security requirements and best practices standards.

[coderabbitai]

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

This pull request modifies Helm deployment configurations for the WSO2 AMP evaluation extension. Changes include adding post-install/post-upgrade Helm hook annotations to a cluster workflow template, adjusting the default namespace handling in a workflow manifest, and updating an API key value in the Helm values configuration.

Changes

Cohort / File(s)	Summary
Helm Hook Configuration deployments/helm-charts/wso2-amp-evaluation-extension/templates/workflow-templates/cluster-workflow-monitor-evaluation.yaml	Added helm.sh/hook and helm.sh/hook-weight annotations to mark the template as a post-install/post-upgrade hook with execution weight of 15.
Workflow Namespace Configuration deployments/helm-charts/wso2-amp-evaluation-extension/templates/workflow-templates/workflow-monitor-evaluation.yaml	Changed the default namespace fallback from Release namespace reference to the literal string "default" when ampEvaluation.workflowNamespace is not provided.
Publisher API Key Configuration deployments/helm-charts/wso2-amp-evaluation-extension/values.yaml	Updated ampEvaluation.publisher.apiKey value from "amp-internal-api-key" to "amp-internal-publisher-api-key".

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Poem

🐰 Hops with delight through deployment files,
Helm hooks are dancing in perfect styles,
Namespaces shifting and keys updated bright,
Configuration changes—smooth as moonlight! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	❓ Inconclusive	The Purpose section clearly describes the changes, but most template sections (Goals, Approach, User stories, Release note, Documentation, Training, Certification, Marketing, Automation tests, Security checks, Samples, Related PRs, Migrations, Test environment, Learning) contain only placeholder text without substantive content.	Complete the remaining sections of the PR description template with relevant details about testing, documentation impact, security verification, and deployment environment to provide a comprehensive review basis.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title mentions 'evaluation monitors not creation' which relates to the Helm hook annotations ensuring workflow resources are created, and 'data publishing error' aligns with the API key update for the publisher configuration.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

📝 Coding Plan

• Generate coding plan for human review comments

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}