Fix endpoint certificate retrieval by using FQDN #12830
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nimsara66
requested review from
tharindu1st,
AnuGayan,
chamilaadhi,
Arshardh,
dushaniw and
tgtshanika
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fix the issue where the 'General Endpoint Configurations' section in the Publisher Portal does not display applied certificates from other APIs with the same domain name.
Approach
The current implementation for retrieving certificates in the Publisher Portal relies on an exact match with the applied endpoint of the API. As a result, if another API shares the same domain name but has a different endpoint path, the associated certificate is correctly applied underneath during backend communication but does not appear in the UI.
Ex:
https://google.comandhttps://google.com/api/v1This PR addresses the issue by replacing the exact match (
=operator) with thelikeoperator and wildcard (%) syntax. This ensures that certificate retrieval is based on the fully qualified domain name (FQDN) rather than the exact endpoint, providing a more accurate and consistent UI representation.Related to
Issue: wso2/api-manager#3527
Internal: https://github.com/wso2-enterprise/wso2-apim-internal/issues/8460