Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intra-vendor model routing support for AI APIs #12870

Conversation

ashera96
Copy link
Contributor

@ashera96 ashera96 commented Feb 9, 2025

No description provided.

@ashera96 ashera96 marked this pull request as ready for review February 9, 2025 19:40
@ashera96 ashera96 changed the base branch from master to intra-vendor-model-routing-feature February 10, 2025 05:23
@ashera96 ashera96 merged commit 4d22f05 into wso2:intra-vendor-model-routing-feature Feb 10, 2025
1 check passed
/*
* Copyright (c) 2025, WSO2 LLC. (http://www.wso2.org) All Rights Reserved.
*
* WSO2 Inc. licenses this file to you under the Apache License,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* WSO2 Inc. licenses this file to you under the Apache License,
* WSO2 LLc. licenses this file to you under the Apache License,

}
}
// /**
// * Validates if the provided LLM provider ID exists in the organization.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove commented out code

FOREIGN KEY (API_UUID) REFERENCES AM_API(API_UUID) ON DELETE CASCADE,
PRIMARY KEY (MAPPING_ID)
);

CREATE TABLE IF NOT EXISTS AM_API_SEQUENCE_BACKEND (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add scripts for other db types

CommonUtils.validateAPIExistence(apiId);
PublisherCommonUtils.updateAPIEndpoint(apiId, endpointId, apIEndpointDTO, organization, apiProvider);
APIEndpointInfo updatedAPIEndpoint = apiProvider.getAPIEndpointByUUID(apiId, endpointId);
APIEndpointDTO updatedAPIEndpointDTO = APIMappingUtil.fromAPIEndpointToDTO(updatedAPIEndpoint);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't find any logic to handling invalid endpoint id passed here. 404 error should be sent if endpoint is not found for the given id.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants