Add Prometheus Support for Choreo Connect #3428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3428 +/- ##
============================================
- Coverage 27.58% 27.56% -0.03%
+ Complexity 3373 3370 -3
============================================
Files 484 484
Lines 52044 52048 +4
Branches 6350 6350
============================================
- Hits 14356 14346 -10
- Misses 36283 36295 +12
- Partials 1405 1407 +2
☔ View full report in Codecov by Sentry. |
NomadXD
reviewed
Sep 14, 2023
NomadXD
reviewed
Sep 14, 2023
slahirucd7
reviewed
Sep 14, 2023
enforcer-parent/enforcer/src/main/resources/prometheus-jmx-config.yml
Outdated
Show resolved
Hide resolved
...test/java/org/wso2/choreo/connect/tests/setup/standalone/CcWithPrometheusMetricsEnabled.java
Show resolved
Hide resolved
slahirucd7
reviewed
Sep 14, 2023
...so2/choreo/connect/tests/testcases/standalone/metrics/PrometheusMetricEndpointsTestCase.java
Outdated
Show resolved
Hide resolved
slahirucd7
reviewed
Sep 14, 2023
slahirucd7
reviewed
Sep 25, 2023
slahirucd7
previously approved these changes
Sep 25, 2023
Co-authored-by: SLahiruC <40932779+slahirucd7@users.noreply.github.com>
renuka-fernando
approved these changes
Oct 2, 2023
dushaniw
approved these changes
Oct 2, 2023
| @@ -196,7 +197,16 @@ func Run(conf *config.Config) { | |||
| }) | |||
| } | |||
|
|
|||
| logger.LoggerMgw.Info("Starting adapter ....") | |||
| logger.LoggerMgw.Info("Starting adapter ....") | |||
There was a problem hiding this comment.
Proper indentation can be added
|
|
||
| for { | ||
| // Start the recordMetrics goroutine | ||
| go func() { |
There was a problem hiding this comment.
Better to add a doc comment explaining the pattern usage of go to create the goroutine and the done <- struct{}{} and <-done signal for parallel(to main thread) but sequential(to each call for recordMetrics) execution of recordMetrics function.
There was a problem hiding this comment.
Fixed through PR #3498
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Approach
Documentation
Related PRs