add scope validation for InternalAPIKeyAuthenticator #3486
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are few checkstyle failures in the PR check. |
VirajSalaka
reviewed
Jan 28, 2024
| @@ -254,6 +261,42 @@ public AuthenticationContext authenticate(RequestContext requestContext) throws | |||
| APISecurityConstants.API_AUTH_GENERAL_ERROR, APISecurityConstants.API_AUTH_GENERAL_ERROR_MESSAGE); | |||
| } | |||
|
|
|||
| private void validateScopes(RequestContext requestContext, JWTClaimsSet payload, JWTTokenPayloadInfo jwtTokenPayloadInfo) | |||
There was a problem hiding this comment.
let's discuss and decide if we need to set these scopes in the backend jwt token as well
rajithacharith
force-pushed
the
choreo
branch
2 times, most recently
from
afe91b7 to
a2a5444
Compare
rajithacharith
force-pushed
the
choreo
branch
from
a2a5444 to
1bf2c6a
Compare
|
Scopes needs to be added to the backend jwt token. Keeping this PR closed as the issue is hold till the other blockers fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Validate scopes for internal api keys.
As mentioned in
[Architecture] [Choreo] Admin configuration for configuring developer portal IdP, scope validation will be added to the API keys. To maintain the current behavior for console users (internal developers) following PR should be merged before thisIssues