Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chunk fetching APIs from Control Plane on startup #3495

Merged
merged 4 commits into from
Mar 1, 2024
Merged

Chunk fetching APIs from Control Plane on startup #3495

merged 4 commits into from
Mar 1, 2024

Conversation

renuka-fernando
Copy link
Contributor

@renuka-fernando renuka-fernando commented Feb 27, 2024 •
edited
Loading

Purpose

Chunk retrieving deployments from controlplane to reduce the overhead to the controlplane.

Issues

Automation tests

  • Unit tests added: Yes
  • Integration tests added: No

Tested environments

Tested in Dev envirionment

Maintainers: Check before merge

  • Assigned 'Type' label
  • Assigned the project
  • Validated respective github issues
  • Assigned milestone to the github issue(s)

Logs

With existing changes

adapter-1   | 2024-02-28 06:20:01 INFO [main.go:39] - [main.startMicroGateway] [-] Starting Choreo Connect Adapter
adapter-1   | 2024-02-28 06:20:37 INFO [adapter.go:339] - [adapter.fetchAPIsOnStartUp] [-] Fetching APIs at startup with the received API UUID list (size: 3998)...
adapter-1   | 2024-02-28 06:27:28 INFO [adapter.go:350] - [adapter.fetchAPIsOnStartUp] [-] Fetching APIs at startup is completed...

With new changes

adapter-1   | 2024-02-29 10:02:22 INFO [main.go:39] - [main.startMicroGateway] [-] Starting Choreo Connect Adapter
adapter-1   | 2024-02-29 10:02:57 INFO [adapter.go:343] - [adapter.fetchAPIsOnStartUp] [-] Fetching chunked APIs... [1/8]
adapter-1   | 2024-02-29 10:03:32 INFO [adapter.go:343] - [adapter.fetchAPIsOnStartUp] [-] Fetching chunked APIs... [2/8]
adapter-1   | 2024-02-29 10:04:07 INFO [adapter.go:343] - [adapter.fetchAPIsOnStartUp] [-] Fetching chunked APIs... [3/8]
adapter-1   | 2024-02-29 10:04:42 INFO [adapter.go:343] - [adapter.fetchAPIsOnStartUp] [-] Fetching chunked APIs... [4/8]
adapter-1   | 2024-02-29 10:05:20 INFO [adapter.go:343] - [adapter.fetchAPIsOnStartUp] [-] Fetching chunked APIs... [5/8]
adapter-1   | 2024-02-29 10:05:57 INFO [adapter.go:343] - [adapter.fetchAPIsOnStartUp] [-] Fetching chunked APIs... [6/8]
adapter-1   | 2024-02-29 10:06:32 INFO [adapter.go:343] - [adapter.fetchAPIsOnStartUp] [-] Fetching chunked APIs... [7/8]
adapter-1   | 2024-02-29 10:07:13 INFO [adapter.go:343] - [adapter.fetchAPIsOnStartUp] [-] Fetching chunked APIs... [8/8]
adapter-1   | 2024-02-29 10:08:50 INFO [adapter.go:351] - [adapter.fetchAPIsOnStartUp] [-] Fetching APIs at startup is completed...

@renuka-fernando
Chunk fetching APIs from Control Plane on startup
2fa3cc6 
Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>
@renuka-fernando
Add unit test: TestChunkSlice
ee389d1 
Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>
VajiraPrabuddhaka
VajiraPrabuddhaka previously approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@VajiraPrabuddhaka VajiraPrabuddhaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

VirajSalaka
VirajSalaka previously approved these changes Feb 28, 2024
View reviewed changes
@renuka-fernando renuka-fernando force-pushed the chunk-retrieve-runtime-artifact branch from c717e04 to a09d415 Compare February 29, 2024 09:43
@renuka-fernando
Update xDS only for the last chunk
4ba980a 
Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>
@renuka-fernando renuka-fernando force-pushed the chunk-retrieve-runtime-artifact branch from a09d415 to 4ba980a Compare February 29, 2024 10:03
VirajSalaka
VirajSalaka previously approved these changes Feb 29, 2024
View reviewed changes
@renuka-fernando
Add comment explaining the reason for not notifying the control plane…
413e080 
… after all chunks

Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>
@renuka-fernando renuka-fernando merged commit 014642b into wso2:choreo Mar 1, 2024
2 of 3 checks passed
@choreo-cicd
Copy link

[succeeded] Controlplane cluster : dev-deployment-v2 : 20240301.13

@choreo-cicd
Copy link

[succeeded] Dataplane(EastUS) cluster : dev-deployment-v2 : 20240301.13

@choreo-cicd
Copy link

[succeeded] Dataplane(NorthEU) cluster : dev-deployment-v2 : 20240301.13

@choreo-cicd
Copy link

[succeeded] : dev-deployment-v2 : 20240301.13

@choreo-cicd
Copy link

[failed] Dataplane(NorthEU) cluster : stage-deployment-v2 : 20240304.2

@choreo-cicd
Copy link

[failed] Controlplane cluster : stage-deployment-v2 : 20240304.2

@choreo-cicd
Copy link

[succeeded] : stage-deployment-v2 : 20240304.2

@choreo-cicd
Copy link

[failed] Dataplane(EastUS) cluster : stage-deployment-v2 : 20240304.2

@choreo-cicd
Copy link

[canceled] Dataplane(EastUS) cluster : stage-deployment-v2 : 20240304.2

@choreo-cicd
Copy link

[succeeded] Dataplane(NorthEU) cluster : stage-deployment-v2 : 20240304.2

@choreo-cicd
Copy link

[succeeded] Controlplane cluster : stage-deployment-v2 : 20240304.2

@choreo-cicd
Copy link

[succeeded] : stage-deployment-v2 : 20240304.2

@choreo-cicd
Copy link

[] Dataplane(EastUS) cluster : stage-deployment-v2 : 20240304.2

@choreo-cicd
Copy link

[] Dataplane(NorthEU) cluster : stage-deployment-v2 : 20240304.2

@choreo-cicd
Copy link

[] Controlplane cluster : stage-deployment-v2 : 20240304.2

@choreo-cicd
Copy link

[] : stage-deployment-v2 : 20240304.2

@choreo-cicd
Copy link

[succeeded] Dataplane(NorthEU) cluster : prod-deployment-v2 : 20240305.4

@choreo-cicd
Copy link

[succeeded] : prod-deployment-v2 : 20240305.4

@choreo-cicd
Copy link

[succeeded] Controlplane cluster : prod-deployment-v2 : 20240305.4

@choreo-cicd
Copy link

[succeeded] Dataplane(EastUS) cluster : prod-deployment-v2 : 20240305.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VirajSalaka VirajSalaka VirajSalaka approved these changes

@malinthaprasan malinthaprasan malinthaprasan approved these changes

@VajiraPrabuddhaka VajiraPrabuddhaka Awaiting requested review from VajiraPrabuddhaka

Assignees
No one assigned
Labels
Status/DeployedToDev Status/DeployedToProd Status/DeployedToStage Type/Improvement Type/Task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@renuka-fernando @choreo-cicd @malinthaprasan @VajiraPrabuddhaka @VirajSalaka