[Choreo] [ws analytics] Fix publishing 101 success requests #3584
Conversation
Thushani-Jayasekera
changed the title
Thushani-Jayasekera
added
test-improvements
Choreo
Type/Improvement
and removed
test-improvements
labels
|
[failed] : dev-deployment-v2 : 20240915.2 |
|
[failed] Dataplane(EastUS) cluster : dev-deployment-v2 : 20240915.2 |
|
[failed] Dataplane(NorthEU) cluster : dev-deployment-v2 : 20240915.2 |
|
[failed] Dataplane(NorthEU) cluster : dev-deployment-v2 : 20240915.3 |
|
[failed] : dev-deployment-v2 : 20240915.3 |
|
[failed] Dataplane(EastUS) cluster : dev-deployment-v2 : 20240915.3 |
|
[failed] Dataplane(EastUS) cluster : dev-deployment-v2 : 20240915.4 |
|
[failed] Dataplane(NorthEU) cluster : dev-deployment-v2 : 20240915.4 |
|
[failed] : dev-deployment-v2 : 20240915.4 |
|
[failed] : dev-deployment-v2 : 20240915.5 |
|
[failed] Dataplane(EastUS) cluster : dev-deployment-v2 : 20240915.5 |
|
[failed] Dataplane(NorthEU) cluster : dev-deployment-v2 : 20240915.5 |
|
[failed] Dataplane(EastUS) cluster : dev-deployment-v2 : 20240915.6 |
|
[failed] Dataplane(NorthEU) cluster : dev-deployment-v2 : 20240915.6 |
|
[failed] Dataplane(EastUS) cluster : dev-deployment-v2 : 20240915.7 |
|
[failed] Dataplane(NorthEU) cluster : dev-deployment-v2 : 20240915.7 |
|
[failed] Dataplane(NorthEU) cluster : dev-deployment-v2 : 20240915.8 |
|
[failed] Dataplane(EastUS) cluster : dev-deployment-v2 : 20240915.8 |
|
[failed] Dataplane(NorthEU) cluster : dev-deployment-v2 : 20240915.9 |
|
[failed] Dataplane(EastUS) cluster : dev-deployment-v2 : 20240915.9 |
|
[failed] Dataplane(EastUS) cluster : stage-deployment-v2 : 20240918.9 |
|
[succeeded] Controlplane cluster : stage-deployment-v2 : 20240918.9 |
|
[succeeded] Dataplane(NorthEU) cluster : stage-deployment-v2 : 20240918.9 |
|
[succeeded] Dataplane(CDP2-WU2) cluster : stage-deployment-v2 : 20240918.9 |
|
[] Controlplane cluster : stage-deployment-v2 : 20240918.10 |
|
[] Dataplane(NorthEU) cluster : stage-deployment-v2 : 20240918.10 |
|
[] Dataplane(CDP2-WU2) cluster : stage-deployment-v2 : 20240918.10 |
|
[] Dataplane(EastUS) cluster : stage-deployment-v2 : 20240918.10 |
|
[succeeded] Controlplane cluster : prod-deployment-v2 : 20240919.4 |
|
[succeeded] Dataplane(NorthEU) cluster : prod-deployment-v2 : 20240919.4 |
|
[succeeded] Dataplane(CDP2-WU2) cluster : prod-deployment-v2 : 20240919.4 |
|
[succeeded] Dataplane(EastUS) cluster : prod-deployment-v2 : 20240919.4 |
Purpose
Currently the WebSocket Access logs with status code 101 are not published in analytics UI. This PR will fix it by using the current default analytics provider.
Later in the handleGRPCLogMsg(StreamAccessLogsMessage message) method we need to define a seperate analytics provider for websocket connections. Currently there is no way of identifying this.
Furthermore this can be improved with access logs been flushed for a duration instead of completion
https://www.envoyproxy.io/docs/envoy/v1.26.8/api-v3/extensions/filters/network/http_connection_manager/v3/http_connection_manager.proto#extensions-filters-network-http-connection-manager-v3-httpconnectionmanager-hcmaccesslogoptions
access_log_flush_interval
(Duration) The interval to flush the above access logs. By default, the HCM will flush exactly one access log on stream close, when the HTTP request is complete. If this field is set, the HCM will flush access logs periodically at the specified interval. This is especially useful in the case of long-lived requests, such as CONNECT and Websockets. Final access logs can be detected via the requestComplete() method of StreamInfo in access log filters, or thru the %DURATION% substitution string. The interval must be at least 1 millisecond.
Issues
Fixes #
Automation tests
Tested environments
Not Tested
Maintainers: Check before merge