-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Insights access logs and configs #3596
Conversation
InsightsLogs: &insightsLog{ | ||
Enable: false, | ||
LogFile: "/dev/stdout", | ||
LoggingFormat: "-", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it work if we simply provided like this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
even this is enabled it will just print '-'. but ideally it is not usable and proper config should apply
...ommons/src/main/java/org/wso2/choreo/connect/enforcer/commons/model/ChoreoComponentInfo.java
Show resolved
Hide resolved
OrganizationID: mgwSwagger.ChoreoComponentInfo.OrganizationID, | ||
ProjectID: mgwSwagger.ChoreoComponentInfo.ProjectID, | ||
choreoComponentInfo := &api.ChoreoComponentInfo{} | ||
if mgwSwagger.ChoreoComponentInfo != nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is something we expect to be mandatory for a given api, we can add a log and monitor from logs for a while.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
discussed and decided we won't require that sort of a log.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not critical atm
[] Dataplane(NorthEU) cluster : dev-deployment-v2 : 20241009.23 |
2 similar comments
[] Dataplane(NorthEU) cluster : dev-deployment-v2 : 20241009.23 |
[] Dataplane(NorthEU) cluster : dev-deployment-v2 : 20241009.23 |
[] : dev-deployment-v2 : 20241009.23 |
2 similar comments
[] : dev-deployment-v2 : 20241009.23 |
[] : dev-deployment-v2 : 20241009.23 |
[] Dataplane(EastUS) cluster : dev-deployment-v2 : 20241009.23 |
2 similar comments
[] Dataplane(EastUS) cluster : dev-deployment-v2 : 20241009.23 |
[] Dataplane(EastUS) cluster : dev-deployment-v2 : 20241009.23 |
[succeeded] Dataplane(EastUS) cluster : stage-deployment-v2 : 20241010.4 |
[failed] Controlplane cluster : stage-deployment-v2 : 20241010.4 |
[] Dataplane(NorthEU) cluster : stage-deployment-v2 : 20241010.4 |
[] Dataplane(EastUS) cluster : stage-deployment-v2 : 20241010.4 |
[succeeded] Dataplane(CDP2-WU2) cluster : prod-deployment-v2 : 20241011.5 |
[succeeded] Dataplane(EastUS) cluster : prod-deployment-v2 : 20241011.5 |
[succeeded] Controlplane cluster : prod-deployment-v2 : 20241011.5 |
Purpose
Support Insights access logs and configs
Issues
Fixes #
Automation tests
Tested environments
Not Tested
Maintainers: Check before merge