Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Insights access logs and configs #3596

Merged
merged 6 commits into from
Oct 9, 2024
Merged

Support Insights access logs and configs #3596

merged 6 commits into from
Oct 9, 2024

Conversation

ruks
Copy link
Contributor

@ruks ruks commented Oct 3, 2024

Purpose

Support Insights access logs and configs

Issues

Fixes #

Automation tests

  • Unit tests added: Yes/No
  • Integration tests added: Yes/No

Tested environments

Not Tested


Maintainers: Check before merge

  • Assigned 'Type' label
  • Assigned the project
  • Validated respective github issues
  • Assigned milestone to the github issue(s)

@CLAassistant
Copy link

CLAassistant commented Oct 3, 2024

CLA assistant check
All committers have signed the CLA.

adapter/pkg/config/log_types.go Outdated Show resolved Hide resolved
adapter/internal/oasparser/config_generator.go Outdated Show resolved Hide resolved
InsightsLogs: &insightsLog{
Enable: false,
LogFile: "/dev/stdout",
LoggingFormat: "-",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it work if we simply provided like this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

even this is enabled it will just print '-'. but ideally it is not usable and proper config should apply

OrganizationID: mgwSwagger.ChoreoComponentInfo.OrganizationID,
ProjectID: mgwSwagger.ChoreoComponentInfo.ProjectID,
choreoComponentInfo := &api.ChoreoComponentInfo{}
if mgwSwagger.ChoreoComponentInfo != nil {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is something we expect to be mandatory for a given api, we can add a log and monitor from logs for a while.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

discussed and decided we won't require that sort of a log.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not critical atm

@ruks ruks merged commit 4a67b46 into wso2:choreo Oct 9, 2024
2 of 3 checks passed
@choreo-cicd
Copy link

[] Dataplane(NorthEU) cluster : dev-deployment-v2 : 20241009.23

2 similar comments
@choreo-cicd
Copy link

[] Dataplane(NorthEU) cluster : dev-deployment-v2 : 20241009.23

@choreo-cicd
Copy link

[] Dataplane(NorthEU) cluster : dev-deployment-v2 : 20241009.23

@choreo-cicd
Copy link

[] : dev-deployment-v2 : 20241009.23

2 similar comments
@choreo-cicd
Copy link

[] : dev-deployment-v2 : 20241009.23

@choreo-cicd
Copy link

[] : dev-deployment-v2 : 20241009.23

@choreo-cicd
Copy link

[] Dataplane(EastUS) cluster : dev-deployment-v2 : 20241009.23

2 similar comments
@choreo-cicd
Copy link

[] Dataplane(EastUS) cluster : dev-deployment-v2 : 20241009.23

@choreo-cicd
Copy link

[] Dataplane(EastUS) cluster : dev-deployment-v2 : 20241009.23

@choreo-cicd
Copy link

[succeeded] Dataplane(EastUS) cluster : stage-deployment-v2 : 20241010.4

@choreo-cicd
Copy link

[failed] Controlplane cluster : stage-deployment-v2 : 20241010.4

@choreo-cicd
Copy link

[] Dataplane(NorthEU) cluster : stage-deployment-v2 : 20241010.4

@choreo-cicd
Copy link

[] Dataplane(EastUS) cluster : stage-deployment-v2 : 20241010.4

@choreo-cicd
Copy link

[succeeded] Dataplane(CDP2-WU2) cluster : prod-deployment-v2 : 20241011.5

@choreo-cicd
Copy link

[succeeded] Dataplane(EastUS) cluster : prod-deployment-v2 : 20241011.5

@choreo-cicd
Copy link

[succeeded] Controlplane cluster : prod-deployment-v2 : 20241011.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants