Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new API Key authenticator impl #3611

Merged
merged 3 commits into from
Oct 29, 2024
Merged

Add new API Key authenticator impl #3611

merged 3 commits into from
Oct 29, 2024

Conversation

mevan-karu
Copy link

Purpose

$subject

Replaces the temp authenticator added with #3603

Issues

Fixes #

Automation tests

  • Unit tests added: Yes/No
  • Integration tests added: Yes/No

Tested environments

Not Tested

Maintainers: Check before merge

  • Assigned 'Type' label
  • Assigned the project
  • Validated respective github issues
  • Assigned milestone to the github issue(s)

VirajSalaka
VirajSalaka reviewed Oct 29, 2024
View reviewed changes
enforcer-parent/enforcer/src/main/java/org/wso2/choreo/connect/enforcer/api/Utils.java Show resolved Hide resolved
...nforcer/src/main/java/org/wso2/choreo/connect/enforcer/security/jwt/APIKeyAuthenticator.java Show resolved Hide resolved
...nforcer/src/main/java/org/wso2/choreo/connect/enforcer/security/jwt/APIKeyAuthenticator.java Outdated
String encodedKeyData = Base64.getEncoder().encodeToString(jsonObject.toJSONString().getBytes());
String newAPIKeyHeaderValue = APIKeyConstants.API_KEY_PREFIX + encodedKeyData + checksum;
// Remove the existing header.
requestContext.getRemoveHeaders().add(ConfigHolder.getInstance().getConfig().getApiKeyConfig()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we do not need it here and it won't work in the expected way as first we add the headers and then process removeHeader map and remove them.

...nforcer/src/main/java/org/wso2/choreo/connect/enforcer/security/jwt/APIKeyAuthenticator.java Show resolved Hide resolved
...t/enforcer/src/main/java/org/wso2/choreo/connect/enforcer/security/jwt/JWTAuthenticator.java Outdated Show resolved Hide resolved
...nforcer/src/main/java/org/wso2/choreo/connect/enforcer/security/jwt/APIKeyAuthenticator.java Show resolved Hide resolved
@renuka-fernando renuka-fernando merged commit c49638e into wso2:choreo Oct 29, 2024
2 of 3 checks passed
@choreo-cicd
Copy link

[failed] Dataplane(EastUS) cluster : dev-deployment-v2 : 20241029.30

@choreo-cicd
Copy link

[failed] Dataplane(NorthEU) cluster : dev-deployment-v2 : 20241029.30

@choreo-cicd
Copy link

[failed] : dev-deployment-v2 : 20241029.30

@choreo-cicd
Copy link

[failed] Dataplane(EastUS) cluster : dev-deployment-v2 : 20241029.31

@choreo-cicd
Copy link

[failed] : dev-deployment-v2 : 20241029.31

@choreo-cicd
Copy link

[failed] Dataplane(NorthEU) cluster : dev-deployment-v2 : 20241029.31

@choreo-cicd
Copy link

[failed] Dataplane(EastUS) cluster : dev-deployment-v2 : 20241029.32

@choreo-cicd
Copy link

[failed] Dataplane(NorthEU) cluster : dev-deployment-v2 : 20241029.32

@choreo-cicd
Copy link

[failed] : dev-deployment-v2 : 20241029.32

@choreo-cicd
Copy link

[failed] Dataplane(EastUS) cluster : dev-deployment-v2 : 20241029.33

@choreo-cicd
Copy link

[failed] Dataplane(NorthEU) cluster : dev-deployment-v2 : 20241029.33

@choreo-cicd
Copy link

[failed] : dev-deployment-v2 : 20241029.33

@choreo-cicd
Copy link

[failed] Dataplane(EastUS) cluster : dev-deployment-v2 : 20241029.34

@choreo-cicd
Copy link

[succeeded] Dataplane(NorthEU) cluster : dev-deployment-v2 : 20241029.34

@choreo-cicd
Copy link

[succeeded] : dev-deployment-v2 : 20241029.34

@choreo-cicd
Copy link

[] Dataplane(NorthEU) cluster : dev-deployment-v2 : 20241030.32

@choreo-cicd
Copy link

[] : dev-deployment-v2 : 20241030.32

@choreo-cicd
Copy link

[] Dataplane(EastUS) cluster : dev-deployment-v2 : 20241030.32

@choreo-cicd
Copy link

[] Dataplane(NorthEU) cluster : stage-deployment-v2 : 20241031.3

@choreo-cicd
Copy link

[] Dataplane(EastUS) cluster : stage-deployment-v2 : 20241031.3

@choreo-cicd
Copy link

[] Controlplane cluster : stage-deployment-v2 : 20241031.3

@choreo-cicd
Copy link

[succeeded] Controlplane cluster : prod-deployment-v2 : 20241101.3

@choreo-cicd
Copy link

[succeeded] Dataplane(NorthEU) cluster : prod-deployment-v2 : 20241101.3

@choreo-cicd
Copy link

[failed] Dataplane(CDP2-WU2) cluster : prod-deployment-v2 : 20241101.3

@choreo-cicd
Copy link

[succeeded] Dataplane(EastUS) cluster : prod-deployment-v2 : 20241101.3

@choreo-cicd
Copy link

[] Dataplane(CDP2-WU2) cluster : prod-deployment-v2 : 20241101.4

@choreo-cicd
Copy link

[] Dataplane(EastUS) cluster : prod-deployment-v2 : 20241101.4

@choreo-cicd
Copy link

[] Controlplane cluster : prod-deployment-v2 : 20241101.4

@choreo-cicd
Copy link

[] Dataplane(NorthEU) cluster : prod-deployment-v2 : 20241101.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VirajSalaka VirajSalaka VirajSalaka approved these changes

@senthalan senthalan senthalan approved these changes

Assignees
No one assigned
Labels
Status/DeployedToDev Status/DeployedToProd Status/DeployedToStage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mevan-karu @choreo-cicd @senthalan @VirajSalaka @renuka-fernando