[Choreo] Upstream connection handling support considering TCP and HTTP #3625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slahirucd7
commented
Dec 3, 2024
slahirucd7
commented
Dec 3, 2024
slahirucd7
commented
Dec 3, 2024
| @@ -129,6 +129,11 @@ func CreateRoutesWithClusters(mgwSwagger model.MgwSwagger, upstreamCerts map[str | |||
| if !strings.Contains(apiLevelEndpointProd.EndpointPrefix, xWso2EPClustersConfigNamePrefix) { | |||
| cluster, address, err := processEndpoints(apiLevelClusterNameProd, apiLevelEndpointProd, | |||
| upstreamCerts, timeout, apiLevelbasePath) | |||
| // assigns specified values for TCP keep-alive and HTTP timeout considering specific organizations | |||
| ok := slices.Contains(config.UpstreamConnectionConfEnabledOrgList, organizationID) | |||
| if ok { | |||
| @@ -189,6 +189,20 @@ retainKeys = ["self_validate_jwt", "issuer", "claim_mappings", "consumer_key_cla | |||
| # Max interval for the Envoy's exponential retry back off algorithm | |||
| maxInterval = "500ms" | |||
|
|
|||
| # TCP configurations applicable with the upstream clusters | |||
| [router.upstream.tCPConfigurations] | |||
There was a problem hiding this comment.
Suggested change
| [router.upstream.tCPConfigurations] | |
| [router.upstream.tcpConfigurations] |
| keepaliveIntervalInMillis = 75000 | ||
|
|
||
| # HTTP configurations applicable with the upstream clusters | ||
| [router.upstream.hTTPConfigurations] |
There was a problem hiding this comment.
Suggested change
| [router.upstream.hTTPConfigurations] | |
| [router.upstream.httpConfigurations] |
| # HTTP configurations applicable with the upstream clusters | ||
| [router.upstream.hTTPConfigurations] | ||
| # Idle timeout in milliseconds for connections | ||
| idleTimeoutInMillis = 120000 |
There was a problem hiding this comment.
This is too low for default. We have to set a value which is more than max response timeout (300s)
Suggested change
| idleTimeoutInMillis = 120000 | |
| idleTimeoutInMillis = 360000 |
| # Maximum number of keep-alive probes to send without response before deciding the connection is dead | ||
| keepaliveProbes = 9 | ||
| # The number of milliseconds between keep-alive probes | ||
| keepaliveIntervalInMillis = 75000 |
There was a problem hiding this comment.
Isn't this too high? Wouldn't something like 30s be better?
Suggested change
| keepaliveIntervalInMillis = 75000 | |
| keepaliveIntervalInMillis = 30000 |
| # The number of milliseconds a connection needs to be idle before keep-alive probes start being sent | ||
| keepaliveTimeInMillis = 120000 | ||
| # Maximum number of keep-alive probes to send without response before deciding the connection is dead | ||
| keepaliveProbes = 9 |
There was a problem hiding this comment.
Too high again?
Suggested change
| keepaliveProbes = 9 | |
| keepaliveProbes = 3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
$subject
Relates with: https://github.com/wso2-enterprise/choreo/issues/32453
Issues
Fixes #
Automation tests
Tested environments
Not Tested
Maintainers: Check before merge