-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use total recombination data if available to calculate recombination rate #262
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #262 +/- ##
==========================================
+ Coverage 92.00% 92.12% +0.12%
==========================================
Files 38 38
Lines 2752 2770 +18
==========================================
+ Hits 2532 2552 +20
+ Misses 220 218 -2 ☔ View full report in Codecov by Sentry. |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
This fixes a bug where the total recombination rate data in the
trparams
files should be used if available. Previously, I was just assuming that the recombination rate is always the sum of the methods that calculate the radiative and dielectronic recombination rates and thus ignoring the trparams data altogether. However, if this total recombination rate data is available, it should take precedence as it is perceived as being more accurate (though there is some controversy around this).