Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename ip property and fix setter logic for abundance, ionization potential, and ionization fraction. #342

Merged
merged 3 commits into from
Jan 28, 2025

rename ip to ionization_potential; refactor setter logic for abundanc…

45644a6
Select commit
Loading
Failed to load commit list.
Merged

Rename ip property and fix setter logic for abundance, ionization potential, and ionization fraction. #342

rename ip to ionization_potential; refactor setter logic for abundanc…
45644a6
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 28, 2025 in 0s

91.11% (+0.08%) compared to 0232377

View this Pull Request on Codecov

91.11% (+0.08%) compared to 0232377

Details

Codecov Report

Attention: Patch coverage is 98.91304% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.11%. Comparing base (0232377) to head (45644a6).

Files with missing lines Patch % Lines
fiasco/ions.py 97.82% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #342      +/-   ##
==========================================
+ Coverage   91.02%   91.11%   +0.08%     
==========================================
  Files          41       41              
  Lines        3432     3454      +22     
==========================================
+ Hits         3124     3147      +23     
+ Misses        308      307       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.