Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cordova #223

Merged
merged 46 commits into from
Jan 29, 2025
Merged

Cordova #223

merged 46 commits into from
Jan 29, 2025

Conversation

kober32
Copy link
Member

@kober32 kober32 commented Jan 15, 2025

Cordova feature.

@hvge We don't expect a full review, more like "into consideration" to be kept in loop.

c0mtru1se and others added 2 commits January 28, 2025 10:32
# Conflicts:
#	android/build.gradle
#	android/src/main/java/com/wultra/android/powerauth/reactnative/PowerAuthModule.java
#	docs/Accessing-Native-PowerAuthSDK.md
#	docs/_Sidebar.md
#	ios/Podfile
#	ios/PowerAuth/PowerAuthModule.m
#	package-lock.json
#	package.json
#	react-native-powerauth-mobile-sdk.podspec
#	src/PowerAuth.ts
#	testapp/_tests/PowerAuth_BiometryInteractive.test.ts
#	testapp/_tests/helpers/RNActivationHelper.ts
#	testapp/ios/Podfile.lock
#	testapp/package-lock.json
#	testapp/package.json
Copy link

@c0mtru1se c0mtru1se left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Both RN and CDV test apps are building & executing tests correctly.
Types and module are correctly emitted for both platforms.

@kober32 kober32 merged commit 0bdbc42 into develop Jan 29, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants