-
Notifications
You must be signed in to change notification settings - Fork 166
feat: add subgraph expressions and tracing attributes #1870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+1,395
−219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a570bac
to
6350075
Compare
Router image scan passed✅ No security vulnerabilities found in image:
|
5f7840c
to
5b415f0
Compare
StarpTech
approved these changes
May 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
65858c3
to
7780ccc
Compare
66fe110
to
683b33c
Compare
683b33c
to
4f33f09
Compare
21fcaba
to
a8cfb06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR adds subgraph expressions and tracing attributes.
Subgraph ExpressionContext
The following is introduced. We only have a minimal expression context for subgraph as it stands. We introduce the following
Add Tracing Attributes
We already have
metric
andtelemetry
attributes, however we do not havetracing
attributes, which can only be used to add values totracing
orspans
. This is introduced as customers might be interested in how long aconnectionAcquire
took for a subgraph.Process subgraph expressions for telemetry
Like we have
attributesWithAuth
we introduceattributesWithSubgraph
which is essentially attributes that usesubgraph
in the expression context. We separate these values out for all three of telemetry / tracing and metric attributes and process them for every subgraph call.Process Subgraph Expressions In Logs And Tracing/Telemetry Attributes
We have expressions for router access logs, however we do not use expressions for the subgraph access logger right now, we add this feature and allow users to define
subgraph
access log expressions.Checklist