Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: audit logs #424

Merged
merged 8 commits into from
Jan 16, 2024
Merged

feat: audit logs #424

merged 8 commits into from
Jan 16, 2024

Conversation

StarpTech
Copy link
Contributor

Motivation and Context

image

@StarpTech StarpTech marked this pull request as ready for review January 16, 2024 16:36
Copy link
Member

@JivusAyrus JivusAyrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have an audit log when the subscription is upgraded right?

One more doubt, what is the diff between subscription.created and subscription.activated

@StarpTech
Copy link
Contributor Author

@JivusAyrus good points. I missed the event.

one more doubt, what is the diff between subscription.created and subscription.activated

created when the user creates a subscription for the first time. Activated once stripe reports that the subscription is active.

Copy link
Member

@thisisnithin thisisnithin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StarpTech StarpTech enabled auto-merge (squash) January 16, 2024 17:34
@StarpTech StarpTech merged commit bb3aa46 into main Jan 16, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants