fix validation of interface fragments in the interface scope (#771)

wundergraph · Apr 15, 2024 · b6a7686 · b6a7686
1 parent ecf0cae
commit b6a7686
Show file tree

Hide file tree

Showing 2 changed files with 59 additions and 1 deletion.
diff --git a/v2/pkg/ast/ast_node.go b/v2/pkg/ast/ast_node.go
@@ -4,6 +4,7 @@ import (
 	"bytes"
 	"fmt"
 	"log"
+	"slices"
 
 	"github.com/wundergraph/graphql-go-tools/v2/pkg/internal/unsafebytes"
 )
@@ -504,7 +505,8 @@ func (d *Document) NodeFragmentIsAllowedOnInterfaceTypeDefinition(fragmentNode,
 	case NodeKindObjectTypeDefinition:
 		return d.NodeImplementsInterfaceFields(fragmentNode, interfaceTypeNode)
 	case NodeKindInterfaceTypeDefinition:
-		return bytes.Equal(d.InterfaceTypeDefinitionNameBytes(fragmentNode.Ref), d.InterfaceTypeDefinitionNameBytes(interfaceTypeNode.Ref))
+		return bytes.Equal(d.InterfaceTypeDefinitionNameBytes(fragmentNode.Ref), d.InterfaceTypeDefinitionNameBytes(interfaceTypeNode.Ref)) ||
+			d.InterfaceNodeIntersectsInterfaceNode(fragmentNode, interfaceTypeNode)
 	case NodeKindUnionTypeDefinition:
 		return d.UnionNodeIntersectsInterfaceNode(fragmentNode, interfaceTypeNode)
 	}
@@ -554,3 +556,18 @@ func (d *Document) UnionNodeIntersectsInterfaceNode(unionNode, interfaceNode Nod
 	}
 	return false
 }
+
+func (d *Document) InterfaceNodeIntersectsInterfaceNode(interfaceNodeA, interfaceNodeB Node) bool {
+	typeNamesImplementingInterfaceA, _ := d.InterfaceTypeDefinitionImplementedByObjectWithNames(interfaceNodeA.Ref)
+	typeNamesImplementingInterfaceB, _ := d.InterfaceTypeDefinitionImplementedByObjectWithNames(interfaceNodeB.Ref)
+
+	hasIntersection := false
+	for _, typeNameB := range typeNamesImplementingInterfaceB {
+		if slices.Contains(typeNamesImplementingInterfaceA, typeNameB) {
+			hasIntersection = true
+			break
+		}
+	}
+
+	return hasIntersection
+}
diff --git a/v2/pkg/astvalidation/operation_validation_test.go b/v2/pkg/astvalidation/operation_validation_test.go
@@ -2799,6 +2799,47 @@ func TestExecutionValidation(t *testing.T) {
 									}`,
 							Fragments(), Invalid)
 					})
+					t.Run("interface into interface", func(t *testing.T) {
+						runWithDefinition(t,
+							`
+								scalar String
+
+								schema {
+									query: Query
+								}
+
+								interface Title {
+									title: String
+								}
+
+								interface Name {
+									name: String
+								}
+
+								type A implements Title & Name {
+									title: String
+									name: String
+								}
+
+								type B implements Name {
+									name: String
+								}
+
+								type Query {
+									titles: [Title]
+								}
+							`,
+							`
+									{
+										titles {
+											title
+											... on Name {
+												name
+											}
+										}
+									}`,
+							Fragments(), Valid)
+					})
 				})
 			})
 		})