-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: delete leftover heartbeat connections #1033
fix: delete leftover heartbeat connections #1033
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch, looks reasonable to me. Can we add a test for it here or in the router?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Do you think we should have one more test with 50 subscriptions at once and make sure that all of them are deleted properly?
e.g.:
require.Eventually
Good point @Noroth , added a test like that |
🤖 I have created a release *beep* *boop* --- ## [2.0.0-rc.143](v2.0.0-rc.142...v2.0.0-rc.143) (2025-01-23) ### Bug Fixes * delete leftover heartbeat connections ([#1033](#1033)) ([f7492d3](f7492d3)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Users reported seeing the below sigfault when a connection to a subgraph is interrupted over multipart:
After investigating, the cause seemed to be a number of times where we deleted the subscription trigger but didn't clean up the heartbeat (which is running in a separate thread), causing it to write on a non-existent context. This PR cleans that up