fix: wait for updates in flight to be delivered before shutting down the trigger #1048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StarpTech
requested changes
Jan 29, 2025
Mmm not sure if this is covered by the router test suite. I can make a test to check on this behavior, ti shouldn't be too complex, thanks for the suggestion! |
StarpTech
reviewed
Feb 3, 2025
alepane21
pushed a commit
that referenced
this pull request
Feb 3, 2025
🤖 I have created a release *beep* *boop* --- ## [2.0.0-rc.147](v2.0.0-rc.146...v2.0.0-rc.147) (2025-02-03) ### Bug Fixes * wait for updates in flight to be delivered before shutting down the trigger ([#1048](#1048)) ([2b44f78](2b44f78)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the last refactor we weren't waiting anymore for the in flight requests to be delivered, so I restored the previous behavior.