fix: crash when requesting trace info without initializing it #704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the trace info was not initialized (e.g. we want to always print it if it's available, but it is not always available), we might get into this scenario.
Aenimus
approved these changes
Dec 15, 2023
fiam
deleted the
alberto/eng-4679-investigate-crash-related-to-tracing
branch
pvormste
pushed a commit
to TykTechnologies/graphql-go-tools
that referenced
this pull request
Feb 29, 2024
…graph#704) If the trace info was not initialized (e.g. we want to always print it if it's available, but it is not always available), we might get into this scenario.
agata-wit
pushed a commit
to TykTechnologies/graphql-go-tools
that referenced
this pull request
Mar 15, 2024
- wundergraph#667 - wundergraph#671 - wundergraph#675 - wundergraph#672 - wundergraph#676 - wundergraph#677 - wundergraph#678 - wundergraph#679 - wundergraph#680 - wundergraph#681 - wundergraph#683 - wundergraph#682 - wundergraph#686 - wundergraph#685 - wundergraph#684 - wundergraph#688 - wundergraph#689 - wundergraph#687 - wundergraph#694 - wundergraph#696 - wundergraph#699 - wundergraph#700 - wundergraph#701 - wundergraph#704 - wundergraph#705 - wundergraph#691 - wundergraph#706 - wundergraph#707 - wundergraph#709 - wundergraph#710 - wundergraph#711 - wundergraph#714 - wundergraph#722 - wundergraph#715 - wundergraph#703 - wundergraph#723 - wundergraph#724 - wundergraph#726 - wundergraph#727 - wundergraph#728 - wundergraph#730 --------- Co-authored-by: Alberto García Hierro <alberto@garciahierro.com> Co-authored-by: Sergiy <818351+devsergiy@users.noreply.github.com> Co-authored-by: Jens Neuse <jens.neuse@gmx.de> Co-authored-by: Nithin Kumar B <nithinkumar5353@gmail.com> Co-authored-by: spetrunin <neyasut@gmail.com>
This was referenced Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the trace info was not initialized (e.g. we want to always print it
if it's available, but it is not always available), we might get into
this scenario.