Use more compact keys, prefer Map to Object #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, first off let me just thank you for an amazing project! I've had so much fun rendering voxel landscapes, a breeze to get started with this. Of course I more or less immediately started to push this to its limits, and encountered some problems when generating large maps.
I think I found some potential improvements:
Map
instead ofObject
to store the voxels and their index appears to be much fasterStage
as well as in theVoxelIndex
, so I replaced this with a reference from theStage
to theVoxelIndex
, which saves memoryUsing this, I have shaved off something like 40% of the heap size when I generate a 512x32x512
Vixel
, and time to initialize the map is down from 8 seconds to 6.7, which is not as significant but at least better.Hope you can find some use for these changes!