Sweep: Add keyboard binding to add current repo, open modal, and clear all data (✓ Sandbox Passed) #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Rollback Files For Sweep
This is an automated message generated by Sweep AI. |
Contributor
Author
Apply Sweep Rules to your PR?
This is an automated message generated by Sweep AI. |
4 tasks
wxharry
reviewed
Feb 2, 2024
Comment on lines
+91
to
+110
| useEffect(() => { | ||
| const handleKeyPress = async (event) => { | ||
| if (event.key === 'a') { | ||
| const { owner, repo } = await GetOwnerRepoName() | ||
| if (owner && repo) { | ||
| const isItemInList = repoList.some( | ||
| (item) => item.owner === owner && item.repo === repo | ||
| ) | ||
| if (!isItemInList) { | ||
| setRepoList(prevRepoList => [...prevRepoList, {owner, repo}]) | ||
| } | ||
| } | ||
| } else if (event.key === 'c') { | ||
| setRepoList([]) | ||
| } | ||
| } | ||
| window.addEventListener('keydown', handleKeyPress) | ||
| return () => window.removeEventListener('keydown', handleKeyPress) | ||
| }, [repoList]) | ||
|
|
Owner
There was a problem hiding this comment.
Sweep: Move this logic to src/contents/modal/index.tsx, where we handle the keydown event 'o'. They should be similar. Thanks!
Owner
|
Sweep: Please Move the logic handling the keyboard event 'a' and 'c' in src/popup/index.tsx to src/contents/modal/index.tsx where we handle the keydown event 'o'. They should be similar. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Feedback: 👎
Description
This pull request adds keyboard bindings to the modal and popup components in order to perform certain actions. It also includes some code cleanup and organization.
Summary
useEffecthook to listen for the 'o' key press in thePlasmoOverlaycomponent insrc/contents/modal/index.tsxhandleKeyPressfunction to open the modal when the 'o' key is presseduseEffecthook to listen for the 'a' and 'c' key presses in theIndexPopupcomponent insrc/popup/index.tsxhandleKeyPressfunction to add the current repository to the list when the 'a' key is pressed, and to clear the list when the 'c' key is pressedGetOwnerRepoNamefunction fromsrc/service/index.tsinsrc/popup/index.tsxFixes #27.
🎉 Latest improvements to Sweep:
💡 To get Sweep to edit this pull request, you can: