feat: add onBeforeMount callback to createIframeUi options #1899
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR introduces an
onBeforeMount
callback to thecreateIframeUi
function. The main motivation is that theallow
attribute must be set before the iframe is injected into the DOM, otherwise browser will not include permission policies specified in it.Manual Testing
wxt-demo
project.entrypoints/iframe-src/index.html
onMount
callback to setallow
attribute toiframe.content.ts
:onMount
toonBeforeMount
and it will prompt you every time you refresh the page.