fix: Don't crash background service worker when using import.meta.url
#402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #402 +/- ##
==========================================
- Coverage 80.89% 80.24% -0.65%
==========================================
Files 107 108 +1
Lines 7761 7782 +21
Branches 706 703 -3
==========================================
- Hits 6278 6245 -33
- Misses 1467 1521 +54
Partials 16 16 ☔ View full report in Codecov by Sentry. |
aklinker1
changed the title
import.meta.urlimport.meta.url
aklinker1
changed the title
import.meta.urlimport.meta.url
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #392.
Vite replaces
import.meta.urlwithdocument.currentScript && document.currentScript.src || new URL("background.js",document.baseURI).hrefby default, which crashes in background service worker sincedocumentisn't defined. Instead, we're now overriding the definition and replacingimport.meta.urlwithself.location.href, which is defined in all possible JS contexts of chrome extensions.