Skip to content

Commit

Permalink
make firebase the last command in the script
Browse files Browse the repository at this point in the history
The exit code of the script should be the exit code of the `firebase ` command. The easiest way to achieve that is to have `firebase` be the last command in the script.

I've removed the (conditional) token deprecation warning output at the end of the script, because it's a duplicate, the warning is still given before the `firebase` command is executed.
  • Loading branch information
kaibolay authored and wzieba committed Jun 26, 2023
1 parent 0d0bad2 commit 83e6de7
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions entrypoint.sh
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,3 @@ firebase \
${RELEASE_NOTES:+ --release-notes "${RELEASE_NOTES}"} \
${INPUT_RELEASENOTESFILE:+ --release-notes-file "${RELEASE_NOTES_FILE}"} \
$( (( $INPUT_DEBUG )) && printf %s '--debug' )

if [ -n "${INPUT_TOKEN}" ] ; then
echo ${TOKEN_DEPRECATED_WARNING_MESSAGE}
fi

0 comments on commit 83e6de7

Please sign in to comment.