Yet Logstore Work 2024 #861
Open
+36,450
−13,243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* hash session_id as a UUID and use for registration * add milt to the contrib on transformer * attempt common statement fields * whoops remove bad constant * try more deranged file path strategy * sure I'll declare the globals * fix recursive call hopefully * don't set session but see if it is predictable * fix 2 remaining tests without session_id * leave timestamp out of it for now
## Improvements * Merge event statements into defaults so event handler authors can override if desired. * Refactor out the need to include timestamp in every expected statement. ## Testing Improvements * Compare statements as nested arrays using `assertEquals()` rather than string comparison. * Add testing utils dir
* set default platform * remove platform from events * dedupe platform in tests * better name for util
* update header * add and expect v1.0.3 * headers only
Enable conformant actors
* add universal debug event * fancy dynamic object for debuggrel * refactor util fn * tolerant debug event * unserialize event other
reenable build matrix and chill code checker
…docker_fix Timestamp and formatting and docker fix
badge awarded
…d a few things. Also fixed match result/response to be correct per xapi
* make survey intro into description * fix tests for desc * report viewed * response submitted
* wiki comment created * comment deleted * hardcode lang for verbs * comments viewed * page viewed
Lesson Statements
badge_viewed
* cert issued * certificate verified * certificate revoked * attempt to add tool_cert plugin in CI * try actual repo
* relax equality looking for correct t/f answer * Correct match question id relation * correct matching response * correct choices response * correct response on gapselect/sequencing * correct truefalse response * fix numerical * refactor numeric and relax types * attempt_becameoverdue * question_manually_graded * make becameoverdue attempt-centric, improve attempt name * refactor review * attempt_centric attempt started * refactor attempt_viewed * remove unneeded cast * reshape submitted
* refactor out assign submission object * use assign_submission in submitted evt * submission (un)lock * submission viewed
* switch survey to submitted to remove conflict * disambiguate scorm content from module * scos dont have intros
* calendar_subscription consolidation * calendar_sub wip * dont mess with the debug event * fix up calendar subscriptions for shipping * clean up docs * correct test docs * refactor subscription object --------- Co-authored-by: Daniel Bell <daniel@yetanalytics.com>
* require context language * refactor default context * ensure objectType, also message id fixes
|
Hi Milt - first off, thank you for this enormous effort. It looks awesome! It's going to take me a bit of time to review, but I'm curious why the CI was removed from pull requests. Could you re-enable that in this PR? |
Hi David! As far as I could tell running CI on every push covers pull requests as well, but I'm happy to turn it back on. |
* add php 8.0 to try and repro bug * expand matrix * try latest * try 8.1 with latest * try with declared prop * update lib path * use package on packagist * try latest ll version * correct xml * nope, ours * install plugins on 405 whoops * combinatorial support explosion * add exclusions of known incompatibilities
|
We added PHP 8.3 compatibility and some other minor fixes. The support range is now PHP 8.1 to 8.3 and moodle 4.1 to 4.5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR:
PR Type