Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add subscribe link to calendar. #67

Merged
merged 1 commit into from
Mar 17, 2024
Merged

Add subscribe link to calendar. #67

merged 1 commit into from
Mar 17, 2024

Conversation

pantierra
Copy link
Collaborator

Implements #65

@xhain-ci
Copy link

xhain-ci commented Mar 5, 2024 •
edited
Loading

Deployment of preview was successful: https://xHain-hackspace-xhain-website-pr-67.surge.sh

@pantierra pantierra marked this pull request as ready for review March 5, 2024 15:14
@gueldenstone
Copy link
Member

image

The rendering of the link looks kind of weird and is not really linking.

@pantierra
Copy link
Collaborator Author

This is on purpose. Because I don't want people to click on it (just leads to an error page in the browser). What would you suggest instead of the code style representation?

@pantierra pantierra force-pushed the feature/caldav-link branch 2 times, most recently from 021ea0f to 779fa98 Compare March 5, 2024 15:59
@pantierra pantierra merged commit 19f0186 into main Mar 17, 2024
1 check passed
@pantierra pantierra deleted the feature/caldav-link branch March 17, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pantierra @xhain-ci @gueldenstone