Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indent cleanup and test_generate with progress bar for test image generation #2

Closed
wants to merge 4 commits into from

Conversation

jopadan
Copy link

@jopadan jopadan commented Jun 15, 2023

No description provided.

@xNWP
Copy link
Owner

xNWP commented Jun 17, 2023

Hi there!

I've seen your commits, and they appear to still be in progress (there's some printf statements for instance). I've also seen the relevant discussion at Panzerschrek/Chasm-Reverse#59 . Are these changes to better suit your use cases? If so, what are they and what are the shortcomings that you hope to address with these changes? Just so that I may better understand the purpose of your PR.

@xNWP xNWP marked this pull request as draft June 17, 2023 22:05
@jopadan jopadan changed the title Indent fixes and use std::bitset<8> in ImageDescriptor for ATTRIBUTES Indent fixes Jun 18, 2023
@jopadan
Copy link
Author

jopadan commented Jun 19, 2023

Sorry for the premature wrong pull request. I've removed the lame garbage printf and IMAGE_ORIGIN changes.

Code changes:

Added features:

@jopadan jopadan changed the title Indent fixes Indent cleanup and test_generate with progress bar for test image generation Jun 20, 2023
@jopadan jopadan marked this pull request as ready for review August 4, 2023 16:19
@jopadan jopadan closed this by deleting the head repository Aug 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants