Skip to content

Security fix: Resolve FastJSON deserialization vulnerability (GHSL-20… #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
artsploit wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Security fix: Resolve FastJSON deserialization vulnerability (GHSL-20… #157

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion KCenter-Base/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@
<dependency>
<groupId>com.alibaba</groupId>
<artifactId>fastjson</artifactId>
<version>1.2.68</version>
<version>2.0.60</version>
</dependency>
</dependencies>
</project>
4 changes: 0 additions & 4 deletions KCenter-Core/src/main/java/org/nesc/ec/bigdata/service/KsqlDbService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
import com.alibaba.fastjson.JSON;
import com.alibaba.fastjson.JSONArray;
import com.alibaba.fastjson.JSONObject;
import com.alibaba.fastjson.parser.ParserConfig;
import org.nesc.ec.bigdata.cache.ConnectCache;
import org.nesc.ec.bigdata.exception.KSQLException;
import org.slf4j.Logger;
Expand Down Expand Up @@ -33,7 +32,6 @@ public String executeKsqlScript(String host,String body)throws KSQLException{
try{
String url = restService.generatorUrl(host,"/ksql");
ResponseEntity<String> responseEntity = sendRequest(url,HttpMethod.POST,buildQuery(body,true));
ParserConfig.getGlobalInstance().setAutoTypeSupport(true);
List<String> messageArray = JSON.parseArray(responseEntity.getBody(), String.class);
if(Objects.nonNull(messageArray) && !CollectionUtils.isEmpty(messageArray)){
JSONObject message = JSON.parseObject(messageArray.get(0));
Expand All @@ -46,7 +44,6 @@ public String executeKsqlScript(String host,String body)throws KSQLException{
}
return "";
}catch (HttpClientErrorException e){
ParserConfig.getGlobalInstance().setAutoTypeSupport(true);
JSONObject message = JSON.parseObject(e.getResponseBodyAsString());
LOGGER.error("execute ksql script has error,",e);
throw new KSQLException(message.getString("message"));
Expand All @@ -57,7 +54,6 @@ public String executeQueryScript(String host, String body,boolean isKsqlQuery) t
try{
String query = isKsqlQuery?"/ksql":"/query";
String url = restService.generatorUrl(host,query);
ParserConfig.getGlobalInstance().setAutoTypeSupport(true);
ResponseEntity<String> responseEntity = sendRequest(url,HttpMethod.POST,buildQuery(body,true));
return responseEntity.getBody();
}catch (HttpClientErrorException e){
Expand Down