This repository has been archived by the owner on May 1, 2024. It is now read-only.
[iOS] Fix crash navigating in Shell and trying to get the navbar visibility #14689
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fix crash navigating in Shell and trying to get the NavBar visibility. Here https://github.com/xamarin/Xamarin.Forms/blob/5.0.0/Xamarin.Forms.Platform.iOS/Renderers/ShellSectionRenderer.cs#L502 the stack could have a null element. In that case, if the ShellSection is null, do not update anything related with the NavBar.
Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Not applicable
Testing Procedure
Try the NuGet package from this PR in this sample: https://github.com/Kukkimonsuta/xamarin-forms-14125
PR Checklist