CA-398425: correctly check for multiple targets in iSCSI

Signed-off-by: Mark Syms <mark.syms@cloud.com>
xapi-project · Sep 4, 2024 · 6e13dcb · 6e13dcb
1 parent 0837303
commit 6e13dcb
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/drivers/LVHDoISCSISR.py b/drivers/LVHDoISCSISR.py
@@ -103,7 +103,8 @@ def create_iscsi_sessions(self, sr_uuid):
         self.iscsiSRs = []
         self.iscsiSRs.append(iscsi)
         saved_exc = None
-        if self.dconf['target'].find(',') == 0 or self.dconf['targetIQN'] == "*":
+        targets = self.dconf['target'].split(',')
+        if len(targets) > 1 or self.dconf['targetIQN'] == "*":
             # Instantiate multiple sessions
             self.iscsiSRs = []
             if self.dconf['targetIQN'] == "*":
@@ -129,7 +130,7 @@ def create_iscsi_sessions(self, sr_uuid):
                     # IQNstring cannot be built with a dictionary iteration because of this
                     IQNstring = self.dconf['multiSession']
                 else:
-                    for tgt in self.dconf['target'].split(','):
+                    for tgt in targets:
                         try:
                             tgt_ip = util._convertDNS(tgt)
                         except: