CA-399643 Use full paths when stopping fairlock on upgrade #708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amend the fairlock upgrade scriptlet so that it uses full paths. This prevents it failing unexpectedly. Also, change it from a %posttrans scriptlet to a %post scriptlet so that the new version will have an effect immediately any new version is available. Signed-off-by: Tim Smith <tim.smith@cloud.com>
MarkSymsCtx
approved these changes
Sep 25, 2024
stormi
reviewed
Sep 25, 2024
| @@ -237,13 +237,16 @@ Manager and some other packages | |||
| %{_unitdir}/fairlock@.service | |||
| %{_libexecdir}/fairlock | |||
|
|
|||
| %posttrans fairlock | |||
| %post fairlock | |||
| ## On upgrade, shut down existing lock services so new ones will | |||
| ## be started. There should be no locks held during upgrade operations | |||
There was a problem hiding this comment.
What allows to ensure that there's no lock at the time of the RPM update?
There was a problem hiding this comment.
The toolstack assures us they do not perform RPM upgrades while simultaneously performing storage management operations. Anyone on the command line who chooses to do an RPM upgrade in the middle of a disk shuffle should expect many more problems than just the odd dropped lock :-)
There was a problem hiding this comment.
Thanks. Is it the fact that the host is disabled during the upgrades which ensures this?
rdn32
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Amend the fairlock upgrade scriptlet so that it uses full paths. This prevents it failing unexpectedly. Also, change it from a %posttrans scriptlet to a %post scriptlet so that the new version will have an effect immediately any new version is available.