CA-400743: perform post snapshot rename in ioretry #715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears that SMB3 filers or Windows hosts can return EACCES in response to a rename of a file over one of the links to a file if the rename is done too soon after the hardlink is made. Allow the rename to be retried in the event of EIO or ACCES. Signed-off-by: Mark Syms <mark.syms@cloud.com>
KevinLCtx
approved these changes
Nov 4, 2024
|
Might this be a kernel bug? It sounds kind of similar to CA-376740 / CP-43606 although that only affects the 6.x kernel. |
Ah, no, we did discuss this ages back and it does look to be an issue in the 6.x kernel series, but the retry seems to successfully work around it and will be belt and braces if we can fix the kernel issue. |
rdn32
approved these changes
Nov 5, 2024
rosslagerwall
approved these changes
Nov 5, 2024
TimSmithCtx
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that SMB3 filers or Windows hosts can return EACCES in response to a rename of a file over one of the links to a file if the rename is done too soon after the hardlink is made. Allow the rename to be retried in the event of EIO or ACCES.