-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change repository to use the default, upstream file layout #704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psafont
force-pushed
the
reorg
branch
8 times, most recently
from
October 7, 2024 13:28
f2c8cad
to
830f190
Compare
robhoes
approved these changes
Oct 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems good to use the standard layout. Besides that, if it works, it works :)
Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
…ture Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
…ture Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
Rename upstream-extra-dummy to dev-tools Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
Ideally the xapi packages would be automatically tracked, but now it's manual through this package Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
And remove unused packages. Some ocaml packages had to be added, they were previously ignored by the command. For some unknown reason dlm is considered unused, but xs-toolstack indirectly depends on it. Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
I know it's not pretty, but there's not much choice if we want to use opam for filtering packages and use bash to process licenses For some reason shellcheck is happy with these cursed runes. Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
This allows to remove some accumulated workarounds because the latest opam is used Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
Now there's no need to separate between two sets of packages. Unify the check and check all packages. Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
Now it uses the opam metadata as the source of truth. It now is able to stitch together lists of licenses to the SPDX format using AND as separator. Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
This is opam 2.3.0~alpha1 Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
lindig
approved these changes
Oct 8, 2024
lindig
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This needed changes in the tooling, as well as the newest version of opam to produce correct cache and tarballs
The change allows the tarball packaging to be directed purely by metadata, avoiding unused and duplicated packages.
This also allows users to contribute to this opam repository in a similar way to how they do to upstream repository
Updates to the repository in this new form can be seen at this branch: psafont/xs-opam@reorg...psafont:xs-opam:plusplus