Integration with Xarray NDPointIndex#44
Conversation
Temporarily remove flake8 (will likely use ruff later).
I agree. Even for the largest meshes, we're not nearly at a point, where the coordinates could not be handled in memory, I think. So feel free to drop dask support here! |
|
This should be good to go in I think. I updated the tests and the documentation and I added warnings for the deprecated API. Unless someone has any objection, I plan to merge this soon and release v0.2.0 right away! |
|
My only request is that you add a page to https://xarray-indexes.readthedocs.io/ :) and write a short blog post |
|
That seems doable :). Actually one of the NDPointIndex adapters implemented in Xoak is already in https://xarray-indexes.readthedocs.io/blocks/ndpoint.html but I can update the note there after releasing Xoak. |
|
nice work, Benoit! |
|
Can you make a pangeo discourse forum post about this, or perhaps you can do a quick blogpost and then make the forum post? I'm sure many people there are interested. |
I took some steps in advance and implemented here the integration with Xarray's
NDPointIndex(pydata/xarray#10478) that will be available soon (likely in the next Xarray release 2025.7).Here is how look the introduction examples by directly reusing Xarray's API:
We could probably start deprecating xoak's API. For simplicity Xarray's
NDPointIndexdoesn't support dask/chunked coordinates and indexers like Xoak currently does. Would it be OK of deprecating that as well? I feel that this experimental feature has never worked really well. We could certainly try supporting it later in Xarray in a more robust way.This would also close #19, #20 and #37.