-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DJ October 2021 #165
DJ October 2021 #165
Conversation
journal/202110.md
Outdated
|
||
- added standard way to show any status change reason (not only censored but now also abandoned and closed) | ||
- support [multiple](https://github.com/decred/politeiagui/pull/2629) billing status changes. Ideally there should be only one (from Active to Completed or Closed), but this allows to correct admin mistakes. It is also possible to temporarily [disable](https://github.com/decred/politeia/pull/1533) status changes. | ||
- improved [identity error](https://github.com/decred/politeiagui/pull/2623) messages |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This improves and standardizes the identity error. The same error is now displayed anytime the user attempts to write data to politeia without their active identity being loaded in the browser. The error message directs them to their user details page to fix the issue and provides a link to do so.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good detail. Added a slightly compressed version.
A side effect of such mentions is it helps to raise awareness about user identity.
journal/202110.md
Outdated
|
||
User-facing changes: | ||
|
||
- added standard way to show any status change reason (not only censored but now also abandoned and closed) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The username of the admin that censored or abandoned the proposal is displayed along with the reason they gave for the status change.
Example: decred/politeiagui#2625 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, added.
journal/202110.md
Outdated
User-facing changes: | ||
|
||
- added standard way to show any status change reason (not only censored but now also abandoned and closed) | ||
- support [multiple](https://github.com/decred/politeiagui/pull/2629) billing status changes. Ideally there should be only one (from Active to Completed or Closed), but this allows to correct admin mistakes. It is also possible to temporarily [disable](https://github.com/decred/politeia/pull/1533) status changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally there should be only one
Maybe specify that this defaults to only allowing a single billing status change, but that this is a configurable setting. If an admin makes a mistake, the sysadmin can temporarily update the setting to allow for the mistake to be corrected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good details, added.
journal/202110.md
Outdated
- added standard way to show any status change reason (not only censored but now also abandoned and closed) | ||
- support [multiple](https://github.com/decred/politeiagui/pull/2629) billing status changes. Ideally there should be only one (from Active to Completed or Closed), but this allows to correct admin mistakes. It is also possible to temporarily [disable](https://github.com/decred/politeia/pull/1533) status changes. | ||
- improved [identity error](https://github.com/decred/politeiagui/pull/2623) messages | ||
- ~14 bug fixes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2638 is also a notable PR. It fixes a handful of comment navigation UX issues that occured when navigating back and forth between the full comments section and a single comment thread. Issues that were fixed:
- Comment filtering preferences (top, new, old, flat mode) were being lost in between thread navigation.
- The "Go Back" button was not working properly.
- Loading indiviudal threads was slow due to unnecessary requests being sent.
- UI flickering was occuring during navigation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the clarification. I extracted comment navigation fixes into their own bullet with some compression (Pi section is getting beefy, which is great).
journal/202110.md
Outdated
- moved [identity](https://github.com/decred/politeia/pull/1530) handling methods to more appropriate places | ||
- added a generic [session store](https://github.com/decred/politeia/pull/1555) (will replace the [legacy](https://github.com/decred/politeia/pull/1554) one that did not have proper separation of concerns) | ||
|
||
{ image candidates: maybe [2625](https://github.com/decred/politeiagui/pull/2625), or just skip this time } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Up to you.
DRAFT: https://github.com/xaur/decred-news/blob/draft202110/journal/202110.md
Dependencies: Send notice in advance so that people can plan their work.
Monthly snapshots: Snapshot data that is hard to obtain later. Ideally, capture it at 1st day of the month at 00:00 UTC.
Writing
{DRAFT}
from titlePublishing
gh-pages
/decred/journals
/decred
and/decred/journals
master
togh-pages
gh-pages
(test indraftXX
if needed) and update other placesHousekeeping
tmp
atmaster
, merge bothdrafts
and the latest draft commit, fast-forwarddrafts
totmp
journal-template.md
in thedocs
branchrelease-checklist-template.md
in thedocs
branch