Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DASHTree] Limit insert live segs to uncovered interval cases #1353

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

CastagnaIT
Copy link
Collaborator

Description

Due to last cleanups to manifest updates now the update behaviour its a bit changed
and if sync is a bit late (could be due to unsupported UTCTiming) currently could insert new live segments
where this should not happens when the period interval is full covered by segments

Motivation and context

fix #1350

How has this been tested?

to test insert live segments: https://livesim.dashif.org/livesim/sts_1691768189/sid_ac07c88f/ato_10/testpic_2s/Manifest.mpd
to test the other case i have no sample stream, feedback is reported by users in issue

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • I have read the Contributing document
  • My code follows the Code Guidelines of this project
  • My change requires a change to the Wiki documentation
  • I have updated the documentation accordingly

@CastagnaIT CastagnaIT added Type: Fix non-breaking change which fixes an issue v21 Omega labels Aug 11, 2023
@glennguy
Copy link
Contributor

Sorry - I approved without checking that a review was requested. Please ping again when ready

@CastagnaIT CastagnaIT merged commit 59c3274 into xbmc:Omega Aug 15, 2023
9 checks passed
@CastagnaIT CastagnaIT deleted the insert_live_seg branch August 15, 2023 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Fix non-breaking change which fixes an issue v21 Omega
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DAZN live stream problems
2 participants