Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] Cleanup to cmakelists and includes #1381

Merged
merged 7 commits into from
Sep 13, 2023

Conversation

CastagnaIT
Copy link
Collaborator

@CastagnaIT CastagnaIT commented Sep 12, 2023

Description

The main goal is to remove the long list of sources declared to the main CMakeLists.txt file that are starting to get very long, and then add a CMakeLists file to each subfolder

since it is strictly related i taken the opportunity to improve also the includes

The XML_STATIC define has been removed from the main CMakeLists because was needed only for the old expat library that now dont exists anymore

Motivation and context

Now that the decrypter refactor has been done i try to do some more deep cleanup

How has this been tested?

played wv drm stream on windows and android

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • I have read the Contributing document
  • My code follows the Code Guidelines of this project
  • My change requires a change to the Wiki documentation
  • I have updated the documentation accordingly

@CastagnaIT CastagnaIT added Type: Cleanup non-breaking change which removes non-working or unmaintained functionality Component: Build v21 Omega WIP labels Sep 12, 2023
GCC version 4.8 its 10 years old
Copy link
Contributor

@glennguy glennguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!

@CastagnaIT CastagnaIT merged commit 616b37e into xbmc:Omega Sep 13, 2023
9 checks passed
@CastagnaIT CastagnaIT deleted the cleanup_cmakelists branch September 13, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Build Type: Cleanup non-breaking change which removes non-working or unmaintained functionality v21 Omega
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants