-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cmakelists] Fix atomic target link to linux #1683
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CastagnaIT
added
Type: Fix
non-breaking change which fixes an issue
Component: Build
v22 Piers
labels
Oct 3, 2024
CastagnaIT
changed the title
[Tests] Fix cmakelists for out-out-tree builds
[Tests] Fix cmakelists for out-of-tree builds
Oct 3, 2024
CastagnaIT
referenced
this pull request
Oct 3, 2024
@CastagnaIT
My system is Linux Debian 12 "bookworm".
|
@zuzia-dev i updated PR commit, this new one should works |
CastagnaIT
changed the title
[Tests] Fix cmakelists for out-of-tree builds
[cmakelists] Fix atomic target link to linux
Oct 8, 2024
@zuzia-dev do you have some time to provide a feedback? |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
looks like "atomic" target link must be specified for linux
Motivation and context
on linux broken build on out-of-tree building
on linux kodi crash on library loading
How has this been tested?
tested under ubuntu, builded out-of-tree
tested android by using jenkins test build
Screenshots (if appropriate):
Types of change
Checklist: