Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cmakelists] Fix atomic target link to linux #1683

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

CastagnaIT
Copy link
Collaborator

@CastagnaIT CastagnaIT commented Oct 3, 2024

Description

looks like "atomic" target link must be specified for linux

Motivation and context

on linux broken build on out-of-tree building
on linux kodi crash on library loading

How has this been tested?

tested under ubuntu, builded out-of-tree
tested android by using jenkins test build

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • I have read the Contributing document
  • My code follows the Code Guidelines of this project
  • My change requires a change to the Wiki documentation
  • I have updated the documentation accordingly

@CastagnaIT CastagnaIT added Type: Fix non-breaking change which fixes an issue Component: Build v22 Piers labels Oct 3, 2024
@CastagnaIT CastagnaIT changed the title [Tests] Fix cmakelists for out-out-tree builds [Tests] Fix cmakelists for out-of-tree builds Oct 3, 2024
@zuzia-dev
Copy link

@CastagnaIT
Unfortunately, with no change, it ends up crashing KODI.

/usr/lib/kodi/kodi-x11: symbol lookup error: /home/debian/.kodi/addons/inputstream.adaptive/inputstream.adaptive.so.22.1.5: undefined symbol: __atomic_store_16

My system is Linux Debian 12 "bookworm".

gcc -v
Using built-in specs.
COLLECT_GCC=gcc
COLLECT_LTO_WRAPPER=/usr/lib/gcc/x86_64-linux-gnu/12/lto-wrapper
OFFLOAD_TARGET_NAMES=nvptx-none:amdgcn-amdhsa
OFFLOAD_TARGET_DEFAULT=1
Target: x86_64-linux-gnu
Configured with: ../src/configure -v --with-pkgversion='Debian 12.2.0-14' --with-bugurl=file:///usr/share/doc/gcc-12/README.Bugs --enable-languages=c,ada,c++,go,d,fortran,objc,obj-c++,m2 --prefix=/usr --with-gcc-major-version-only --program-suffix=-12 --program-prefix=x86_64-linux-gnu- --enable-shared --enable-linker-build-id --libexecdir=/usr/lib --without-included-gettext --enable-threads=posix --libdir=/usr/lib --enable-nls --enable-clocale=gnu --enable-libstdcxx-debug --enable-libstdcxx-time=yes --with-default-libstdcxx-abi=new --enable-gnu-unique-object --disable-vtable-verify --enable-plugin --enable-default-pie --with-system-zlib --enable-libphobos-checking=release --with-target-system-zlib=auto --enable-objc-gc=auto --enable-multiarch --disable-werror --enable-cet --with-arch-32=i686 --with-abi=m64 --with-multilib-list=m32,m64,mx32 --enable-multilib --with-tune=generic --enable-offload-targets=nvptx-none=/build/gcc-12-bTRWOB/gcc-12-12.2.0/debian/tmp-nvptx/usr,amdgcn-amdhsa=/build/gcc-12-bTRWOB/gcc-12-12.2.0/debian/tmp-gcn/usr --enable-offload-defaulted --without-cuda-driver --enable-checking=release --build=x86_64-linux-gnu --host=x86_64-linux-gnu --target=x86_64-linux-gnu
Thread model: posix
Supported LTO compression algorithms: zlib zstd
gcc version 12.2.0 (Debian 12.2.0-14)

cmake --version
cmake version 3.30.3

@CastagnaIT
Copy link
Collaborator Author

@zuzia-dev i updated PR commit, this new one should works

@CastagnaIT CastagnaIT changed the title [Tests] Fix cmakelists for out-of-tree builds [cmakelists] Fix atomic target link to linux Oct 8, 2024
@CastagnaIT
Copy link
Collaborator Author

@zuzia-dev do you have some time to provide a feedback?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Build Type: Fix non-breaking change which fixes an issue v22 Piers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants