Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CurlUtils] Removed deprecated use of ADDON_READ_CHUNKED #1721

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

CastagnaIT
Copy link
Collaborator

@CastagnaIT CastagnaIT commented Nov 7, 2024

Description

ADDON_READ_CHUNKED is now deprecated
plus adding ADDON_READ_NO_BUFFER, ADDON_READ_AUDIO_VIDEO has no more effect and has been removed

Motivation and context

as discussion on PR xbmc/xbmc#25158

How has this been tested?

some streams with isadaptive samples addon that contains also subtitles

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • I have read the Contributing document
  • My code follows the Code Guidelines of this project
  • My change requires a change to the Wiki documentation
  • I have updated the documentation accordingly

@CastagnaIT CastagnaIT added Type: Improvement non-breaking change which improves existing functionality v22 Piers labels Nov 7, 2024
@CastagnaIT CastagnaIT marked this pull request as ready for review November 8, 2024 06:47
@CastagnaIT CastagnaIT merged commit a1a28e0 into xbmc:Piers Nov 8, 2024
10 checks passed
@CastagnaIT CastagnaIT deleted the deprecated_curl_flag branch November 8, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Improvement non-breaking change which improves existing functionality v22 Piers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant