Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Discard ERC20 Synths for EVM aprovals #1078

Merged
merged 3 commits into from
Mar 21, 2024

Conversation

stoicdev6
Copy link
Contributor

Add validation that allows synthetics to be discarded from EVM approvals

Copy link
Contributor

@0xp3gasus 0xp3gasus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice bug found!! Add this bug fix in mayachain-amm.ts too.

@stoicdev6
Copy link
Contributor Author

Nice bug found!! Add this bug fix in mayachain-amm.ts too.

Done!

e107322

@stoicdev6 stoicdev6 requested a review from 0xp3gasus March 18, 2024 22:27
@0xp3gasus
Copy link
Contributor

Nice! Please create the changeset files following the CONTRIBUTING.md file

@stoicdev6
Copy link
Contributor Author

Nice! Please create the changeset files following the CONTRIBUTING.md file

Done!

Copy link
Contributor

@0xp3gasus 0xp3gasus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!!

@0xp3gasus 0xp3gasus merged commit b2e198f into xchainjs:master Mar 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants