fix(linstorvolumemanager): don't allow InUse volumes to be deleted #106
+38
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klmp200
force-pushed
the
linstor_protect_in_use_volume
branch
from
2e28b7a to
a86786c
Compare
klmp200
force-pushed
the
linstor_protect_in_use_volume
branch
from
a86786c to
e7af4ae
Compare
Millefeuille42
approved these changes
Nov 7, 2025
Wescoeur
requested changes
Nov 13, 2025
klmp200
force-pushed
the
linstor_protect_in_use_volume
branch
from
e7af4ae to
91916fe
Compare
klmp200
force-pushed
the
linstor_protect_in_use_volume
branch
5 times, most recently
from
91916fe to
a90db03
Compare
Millefeuille42
approved these changes
Nov 17, 2025
Millefeuille42
left a comment
Millefeuille42
left a comment
There was a problem hiding this comment.
Not blocking. Other than that, LGTM.
klmp200
force-pushed
the
linstor_protect_in_use_volume
branch
from
a90db03 to
e85e3e9
Compare
Wescoeur
force-pushed
the
3.2.12-8.3
branch
3 times, most recently
from
66c7c8e to
aaaab27
Compare
klmp200
force-pushed
the
linstor_protect_in_use_volume
branch
from
e85e3e9 to
04276e8
Compare
Wescoeur
requested changes
Dec 9, 2025
| self._ensure_volume_exists(volume_uuid) | ||
| self.ensure_volume_is_not_locked(volume_uuid) | ||
|
|
||
| is_volume_in_use = any(node["in-use"] for node in self.get_resource_info(volume_uuid)["nodes"].values()) |
Member
There was a problem hiding this comment.
Honestly, I don't remember exactly what we said, but: Honestly, I don't remember exactly what we said, but: how many seconds do you estimate the cost of this call to be? For example, if we have 500 resources in the database?
Author
There was a problem hiding this comment.
It was 0.00475s for a 3 nodes linstor setup
Author
There was a problem hiding this comment.
After further testing, we can confirm that get_resource_info gets called before anyway.
Calling the linstor api with filters is 10 times slower compared to just looking up at our cache.
Fix some typo in docstring Signed-off-by: Antoine Bartuccio <antoine.bartuccio@vates.tech>
klmp200
force-pushed
the
linstor_protect_in_use_volume
branch
from
04276e8 to
336c03f
Compare
Author
|
All good :) |
klmp200
force-pushed
the
linstor_protect_in_use_volume
branch
from
336c03f to
8f06d53
Compare
Check for usage status before deleting a linstor volume and raise an appropriate error if this happens Signed-off-by: Antoine Bartuccio <antoine.bartuccio@vates.tech>
klmp200
force-pushed
the
linstor_protect_in_use_volume
branch
from
8f06d53 to
aa72d44
Compare
Wescoeur
approved these changes
Dec 11, 2025
Nambrok
approved these changes
Dec 12, 2025
Millefeuille42
approved these changes
Dec 15, 2025
Member
|
@klmp200 Can you add |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check for usage status before deleting a linstor volume and raise an appropriate error if this happens