lib/host: Avoid using identical source and destination paths in execute_script scp #334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ydirson
requested changes
Jul 2, 2025
rushikeshjadhav
force-pushed
the
issue-325-host-execute-script
branch
from
87dab23 to
9414d56
Compare
rushikeshjadhav
force-pushed
the
issue-325-host-execute-script
branch
from
9414d56 to
1963450
Compare
Millefeuille42
approved these changes
Sep 19, 2025
Wescoeur
requested changes
Sep 19, 2025
lib/host.py
Outdated
Comment on lines
235
to
236
| self.scp(script.name, remote_path) | ||
| self.ssh(['chmod', '0755', remote_path]) |
Member
There was a problem hiding this comment.
Should probably be moved in try scope in case for some reason a call fails even if unlikely.
Contributor
Author
There was a problem hiding this comment.
Sure, have moved them.
…te_script scp Using the same path for both source and destination may cause scp to fail, especially when the source path (e.g. a temp path on macOS) does not exist on the remote system. Thus, resorting to use mktemp on destination. Signed-off-by: Rushikesh Jadhav <rushikesh7@gmail.com>
rushikeshjadhav
force-pushed
the
issue-325-host-execute-script
branch
from
1963450 to
04aa555
Compare
Millefeuille42
approved these changes
Sep 23, 2025
glehmann
approved these changes
Oct 2, 2025
Contributor
Author
Contributor
Author
|
@stormi please see if we need more approvals before merging this. |
stormi
approved these changes
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the same path for both source and destination may cause scp to fail, especially when the source path (e.g. a temp path on macOS) does not exist on the remote system. Thus, resorting to use
mktempon destination.