Storage Tests for qcow2 vdi image format #339

rushikeshjadhav · 2025-07-08T12:26:23Z

Incorporating image-format fixture into following SR types for storage tests

ext
lvm
xfs
zfs
largeblock
nfs

tests/storage/lvm/conftest.py

tests/storage/xfs/conftest.py

tests/storage/zfs/conftest.py

tests/storage/zfsvol/conftest.py

Wescoeur · 2025-09-30T14:13:27Z

tests/storage/zfsvol/test_zfsvol_sr.py

+        sr = host.sr_create('zfs-vol', "ZFS-local-SR-test", {
+            'device': '/dev/' + sr_disk_wiped,
+            'preferred-image-formats': image_format
+        }, verify=True)


Did you test it @rushikeshjadhav ? We don't support QCOW2 with ZFS vol driver (SMAPIv3 plugin).
So we must not add image_format for this one.

Right, although the test passes, its volume is not of qcow2 format. Will remove it and add additional checks for qcow2 VDI validation.

Added additional check for qcow2 VDI validation as well with test_vdi_image_format.

tests/storage/conftest.py

tests/storage/ext/conftest.py

glehmann · 2025-10-02T14:27:51Z

The CI workflow is not run on the PR. We should run it before merging.

glehmann · 2025-10-02T14:44:36Z

There are a few problems to fix:

❯ mypy --install-types --non-interactive lib/ conftest.py pkgfixtures.py tests/
  pyright lib/ conftest.py pkgfixtures.py
  ruff check lib/ tests/
  flake8
tests/install/test.py:88: error: Value of type "object" is not indexable  [index]
tests/install/test.py:342: error: Value of type "object" is not indexable  [index]
Found 2 errors in 1 file (checked 191 source files)
WARNING: there is a new pyright version available (v1.1.402 -> v1.1.406).
Please install the new version or set PYRIGHT_PYTHON_FORCE_VERSION to `latest`

0 errors, 0 warnings, 0 informations
All checks passed!
./tests/storage/largeblock/conftest.py:17:19: E128 continuation line under-indented for visual indent

glehmann · 2025-10-02T14:46:14Z

@rushikeshjadhav the CI should run when using a branch directly in this repository.

stormi

Automatically installing packages that support qcow2 could have been a good idea, but here it might cause more friction than it avoids.

tests/storage/conftest.py

stormi · 2025-11-24T15:27:50Z

Why haven't we merged this one yet?

glehmann · 2025-11-25T10:31:21Z

Why haven't we merged this one yet?

Tests are currently running in the CI. Will be merged soon hopefully :)

stormi · 2025-11-25T16:47:42Z

It will require a last rebase, too.

rushikeshjadhav · 2025-12-01T06:28:55Z

It will require a last rebase, too.

Will get the rebase done and update the branch.

glehmann · 2025-12-08T18:19:02Z

FYI, a successful full CI run was done with this branch.

rzr · 2025-12-08T19:59:43Z

FYI, a successful full CI run was done with this branch.

great, Is there anything to be done before merging, meanwhile please double check and mark open discussions resolved

tests/storage/largeblock/test_largeblock_sr.py

… format Signed-off-by: Rushikesh Jadhav <rushikesh7@gmail.com>

…cow2 vdi image format Signed-off-by: Rushikesh Jadhav <rushikesh7@gmail.com>

… format Signed-off-by: Rushikesh Jadhav <rushikesh7@gmail.com>

glehmann · 2025-12-15T10:32:29Z

If it's ok for everyone, I'll merge this PR this afternoon.

stormi · 2025-12-15T10:49:57Z

If it's ok for everyone, I'll merge this PR this afternoon.

We need stable CI for this week's round of updates. Is it safe?

glehmann · 2025-12-15T12:58:26Z

I think so, but the only way to be sure is to run the CI on this branch

rzr · 2025-12-17T08:07:22Z

I think so, but the only way to be sure is to run the CI on this branch

is there anything blocking, doing it ? if it helps you can use forks and reset your master branch to avoid changing branches names

stormi · 2025-12-17T17:59:33Z

is there anything blocking, doing it ? if it helps you can use forks and reset your master branch to avoid changing branches names

The availability of hardware was blocking it. But now it can likely be merged, if that's OK on @Nambrok's side (he was running tests for the qcow2 release).

Nambrok · 2025-12-19T14:22:09Z

@glehmann Up, are we good with merging it? No tests are running at the moment.

glehmann · 2025-12-19T14:24:55Z

I've relaunched a complete run with this PR and the integrity PRs this morning, to be sure :)

rushikeshjadhav marked this pull request as draft July 8, 2025 12:26

rushikeshjadhav force-pushed the storage-qcow2 branch from 0610307 to c421cc4 Compare July 9, 2025 11:14

rushikeshjadhav requested a review from Nambrok July 10, 2025 12:21

rushikeshjadhav force-pushed the storage-qcow2 branch 2 times, most recently from 1d35ab2 to da6c5d5 Compare September 18, 2025 17:35

rushikeshjadhav marked this pull request as ready for review September 18, 2025 17:41

rushikeshjadhav requested a review from Wescoeur September 18, 2025 17:42

rushikeshjadhav mentioned this pull request Sep 18, 2025

Add qcow2 parameterized tests #335

Closed

Millefeuille42 requested changes Sep 23, 2025

View reviewed changes

tests/storage/lvm/conftest.py Outdated Show resolved Hide resolved

tests/storage/xfs/conftest.py Outdated Show resolved Hide resolved

tests/storage/zfs/conftest.py Outdated Show resolved Hide resolved

tests/storage/zfsvol/conftest.py Outdated Show resolved Hide resolved

rushikeshjadhav force-pushed the storage-qcow2 branch from da6c5d5 to 5ecdfa2 Compare September 23, 2025 17:50

rushikeshjadhav requested review from Millefeuille42 and stormi September 23, 2025 17:52

Millefeuille42 approved these changes Sep 24, 2025

View reviewed changes

glehmann self-requested a review September 30, 2025 13:06

Wescoeur approved these changes Sep 30, 2025

View reviewed changes

Wescoeur requested changes Sep 30, 2025

View reviewed changes

rushikeshjadhav force-pushed the storage-qcow2 branch 3 times, most recently from 38db6d5 to 79264c0 Compare October 1, 2025 14:32

rushikeshjadhav marked this pull request as draft October 1, 2025 14:37

glehmann reviewed Oct 1, 2025

View reviewed changes

tests/storage/conftest.py Outdated Show resolved Hide resolved

tests/storage/ext/conftest.py Outdated Show resolved Hide resolved

rushikeshjadhav force-pushed the storage-qcow2 branch from 79264c0 to 6360b2e Compare October 2, 2025 12:34

rushikeshjadhav marked this pull request as ready for review October 2, 2025 12:35

rushikeshjadhav force-pushed the storage-qcow2 branch from 6360b2e to 0e5f73a Compare October 2, 2025 12:58

glehmann approved these changes Oct 2, 2025

View reviewed changes

stormi reviewed Oct 2, 2025

View reviewed changes

tests/storage/conftest.py Outdated Show resolved Hide resolved

tests/storage/conftest.py Outdated Show resolved Hide resolved

rushikeshjadhav force-pushed the storage-qcow2 branch from 0e5f73a to 6426939 Compare October 3, 2025 12:26

stormi requested review from stormi and removed request for stormi November 24, 2025 15:27

rushikeshjadhav force-pushed the storage-qcow2 branch from 9f1a899 to f0875ff Compare December 2, 2025 07:15

rushikeshjadhav requested a review from a team as a code owner December 2, 2025 07:15

rzr approved these changes Dec 2, 2025

View reviewed changes

Nambrok reviewed Dec 9, 2025

View reviewed changes

tests/storage/largeblock/test_largeblock_sr.py Outdated Show resolved Hide resolved

rushikeshjadhav added 6 commits December 12, 2025 00:00

tests/storage/ext: Updated ext to handle both vhd and qcow2 vdi image…

fd94a13

… format Signed-off-by: Rushikesh Jadhav <rushikesh7@gmail.com>

tests/storage/lvm: Updated lvm to handle both vhd and qcow2 vdi image…

6f4632f

… format Signed-off-by: Rushikesh Jadhav <rushikesh7@gmail.com>

tests/storage/xfs: Updated xfs to handle both vhd and qcow2 vdi image…

e2fb23a

… format Signed-off-by: Rushikesh Jadhav <rushikesh7@gmail.com>

tests/storage/zfs: Updated zfs to handle both vhd and qcow2 vdi image…

0c9978f

… format Signed-off-by: Rushikesh Jadhav <rushikesh7@gmail.com>

tests/storage/largeblock: Updated largeblock to handle both vhd and q…

f286c18

…cow2 vdi image format Signed-off-by: Rushikesh Jadhav <rushikesh7@gmail.com>

tests/storage/nfs: Updated nfs to handle both vhd and qcow2 vdi image…

8da8462

… format Signed-off-by: Rushikesh Jadhav <rushikesh7@gmail.com>

rushikeshjadhav force-pushed the storage-qcow2 branch from f0875ff to 8da8462 Compare December 12, 2025 07:47

rushikeshjadhav requested a review from a team as a code owner December 12, 2025 07:47

stormi requested a review from Nambrok December 15, 2025 10:33

Nambrok approved these changes Dec 15, 2025

View reviewed changes

Nambrok mentioned this pull request Dec 16, 2025

xva export import tests #367

Open

Storage Tests for qcow2 vdi image format #339

Are you sure you want to change the base?

Storage Tests for qcow2 vdi image format #339

Uh oh!

Conversation

rushikeshjadhav commented Jul 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Wescoeur Sep 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rushikeshjadhav Oct 1, 2025

Choose a reason for hiding this comment

Uh oh!

rushikeshjadhav Oct 7, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

glehmann commented Oct 2, 2025

Uh oh!

glehmann commented Oct 2, 2025

Uh oh!

glehmann commented Oct 2, 2025

Uh oh!

stormi left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

stormi commented Nov 24, 2025

Uh oh!

glehmann commented Nov 25, 2025

Uh oh!

stormi commented Nov 25, 2025

Uh oh!

rushikeshjadhav commented Dec 1, 2025

Uh oh!

glehmann commented Dec 8, 2025

Uh oh!

rzr commented Dec 8, 2025

Uh oh!

Uh oh!

glehmann commented Dec 15, 2025

Uh oh!

stormi commented Dec 15, 2025

Uh oh!

glehmann commented Dec 15, 2025

Uh oh!

rzr commented Dec 17, 2025

Uh oh!

stormi commented Dec 17, 2025

Uh oh!

Nambrok commented Dec 19, 2025

Uh oh!

glehmann commented Dec 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

rushikeshjadhav commented Jul 8, 2025 •

edited

Loading

Wescoeur Sep 30, 2025 •

edited

Loading

stormi left a comment •

edited

Loading

glehmann commented Dec 19, 2025 •

edited

Loading