vdi export/import tests #368
Conversation
glehmann
force-pushed
the
gln/vdi-export-integrity
branch
2 times, most recently
from
230f06d to
9c9cc72
Compare
glehmann
force-pushed
the
gln/xva-export-integrity
branch
from
04dc842 to
40b31bf
Compare
glehmann
force-pushed
the
gln/vdi-export-integrity
branch
from
9c9cc72 to
92c11bb
Compare
rzr
left a comment
rzr
left a comment
There was a problem hiding this comment.
Can't duplicated code be factorized ? or this is not desired in context of pytests ?
We do apply this principle in general, I don't know why not in this specific case, but I agree, we could definitely move the repeated code to a utility function, as we've done for live migration tests in the same storage test packages. |
It's just because at first there was a significant number of differences, but most of them are gone. I'll move it to a utility function |
glehmann
force-pushed
the
gln/xva-export-integrity
branch
from
40b31bf to
b0b5cde
Compare
glehmann
force-pushed
the
gln/vdi-export-integrity
branch
2 times, most recently
from
5e92156 to
6fe53b8
Compare
glehmann
force-pushed
the
gln/xva-export-integrity
branch
from
b0b5cde to
5d82813
Compare
glehmann
force-pushed
the
gln/xva-export-integrity
branch
from
5d82813 to
37110a4
Compare
glehmann
force-pushed
the
gln/vdi-export-integrity
branch
from
6fe53b8 to
17fc45a
Compare
glehmann
force-pushed
the
gln/xva-export-integrity
branch
from
37110a4 to
f6c3f34
Compare
glehmann
force-pushed
the
gln/vdi-export-integrity
branch
from
17fc45a to
9ddd3f9
Compare
glehmann
force-pushed
the
gln/xva-export-integrity
branch
from
f6c3f34 to
ef699b4
Compare
glehmann
force-pushed
the
gln/vdi-export-integrity
branch
from
9ddd3f9 to
26a1a1d
Compare
| imported_vm.destroy() | ||
| vm.host.ssh(f'rm -f {xva_path}') | ||
|
|
||
| ImageFormat = Literal['vhd', 'qcow2'] |
There was a problem hiding this comment.
This might have its place in lib/vdi.py?
There was a problem hiding this comment.
You could use it for the type of the parameter of create_vdi too
There was a problem hiding this comment.
It would be nice indeed, but validating the type from xe requires some extra work that I began in https://github.com/xcp-ng/xcp-ng-tests/pull/317/commits, and that I might re-open
|
|
||
| def vdi_export_import(vm: VM, sr: SR, image_format: ImageFormat): | ||
| vdi = sr.create_vdi(image_format=image_format) | ||
| image_path = f'/tmp/{vdi.uuid}.{image_format}' |
There was a problem hiding this comment.
I have seen usage of /tmp elsewhere will it make the test re-entrant ? may safer tmp dir used to avoid potential overlap
There was a problem hiding this comment.
The usage of vdi's uuid should prevent any problem on that side.
Note that this is more for the future though, as the tests are currently mostly sequential.
There was a problem hiding this comment.
yes it is not blocking, just something that popped to my mind while looking the code
I would be tempted to write in a more volatile space, like in a local tmp folder job directory ? this way we are sure those files will not remain if not deleted by test, it can be done in later PR more globally
glehmann
force-pushed
the
gln/xva-export-integrity
branch
from
ef699b4 to
8993a77
Compare
glehmann
force-pushed
the
gln/vdi-export-integrity
branch
from
26a1a1d to
a3c5bba
Compare
glehmann
force-pushed
the
gln/xva-export-integrity
branch
from
8993a77 to
26128a1
Compare
glehmann
force-pushed
the
gln/vdi-export-integrity
branch
from
a3c5bba to
6c77a9b
Compare
Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech>
Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech>
Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech>
Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech>
Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech>
Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech>
Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech>
Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech>
glehmann
force-pushed
the
gln/vdi-export-integrity
branch
from
6c77a9b to
5d6a4d4
Compare
glehmann
force-pushed
the
gln/xva-export-integrity
branch
from
26128a1 to
22c1258
Compare
No description provided.