Strip HTML tags before sharing in Facebook #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shri3k
reviewed
Jul 18, 2017
| @@ -232,6 +232,7 @@ | |||
| this.shareFacebook = function(e) { | |||
| e.preventDefault(); | |||
| var text = self.htmlSelection.replace(/<p[^>]*>/ig,'\n').replace(/<\/p>| /ig,'').trim(); | |||
| text = text.replace(/<\/?[^>]+(>|$)/g, ""); // Remove HTML tags, like <h3>foo</h3>bar => foobar | |||
There was a problem hiding this comment.
Nice catch. However, I'm not sure why self.htmlSelection was chosen here. I think self.textSelection would make a lot more sense as it already gives us just plain text. @xdamman, would you like to chime in here?
There was a problem hiding this comment.
Yep, make sense. Using textSelection makes more sense than htmlSelection, and I guess it'll solve the problem anyway.
There was a problem hiding this comment.
Feel free to send a PR with the textSelection change if it's urgent. I think it's safe to say that textSelection is the better solution to this.
shri3k
force-pushed
the
develop
branch
2 times, most recently
from
2b84818 to
eb2c201
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When sharing to Facebook it writes HTML tags, like
<strong>or even<h3, for example.This will strip all HTML tags before sharing to Facebook.