Fixed Table inline popup buttons issue #1129

Issue: #1129)
xdan · May 10, 2024 · 250bfba · 250bfba
1 parent 012d0c9
commit 250bfba
Show file tree

Hide file tree

Showing 3 changed files with 257 additions and 183 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -9,6 +9,12 @@
 > -   :house: [Internal]
 > -   :nail_care: [Polish]
 
+## 4.2.13
+
+### :bug: Bug Fix
+
+-   [Table inline popup buttons issue #1129](https://github.com/xdan/jodit/issues/1129)
+
 ## 4.2.8
 
 ### :rocket: New Feature
@@ -2614,11 +2620,11 @@ Related with https://github.com/xdan/jodit/issues/574. In some cases need to lim
 -   @property {IUIOption[]} link.selectOptionsClassName=[] The list of the option for the select (to use with
     modeClassName="select")
 -   ex: [
--                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                             	{ value: "", text: "" },
--                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                             	{ value: "val1", text: "text1" },
--                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                             	{ value: "val2", text: "text2" },
--                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                             	{ value: "val3", text: "text3" }
--                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                             ]
+-                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                               	{ value: "", text: "" },
+-                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                               	{ value: "val1", text: "text1" },
+-                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                               	{ value: "val2", text: "text2" },
+-                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                               	{ value: "val3", text: "text3" }
+-                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                               ]
     PR: https://github.com/xdan/jodit/pull/577 Thanks @s-renier-taonix-fr
 
 ##### New option `statusbar: boolean = true`

diff --git a/src/plugins/inline-popup/config/items/cells.ts b/src/plugins/inline-popup/config/items/cells.ts
@@ -64,11 +64,15 @@ export default [
 			tableaddcolumnbefore: 'Insert column before',
 			tableaddcolumnafter: 'Insert column after'
 		},
-		exec: (editor, table, { control }): void => {
+		exec: (editor, table, { control }): void | false => {
 			if (!isJoditObject(editor)) {
 				return;
 			}
 
+			if (!control.args) {
+				return false;
+			}
+
 			const command = cmd(control);
 
 			editor.execCommand(command, false, table);
@@ -81,11 +85,15 @@ export default [
 			tableaddrowbefore: 'Insert row above',
 			tableaddrowafter: 'Insert row below'
 		},
-		exec: (editor, table, { control }): void => {
+		exec: (editor, table, { control }): void | false => {
 			if (!isJoditObject(editor)) {
 				return;
 			}
 
+			if (!control.args) {
+				return false;
+			}
+
 			const command = cmd(control);
 
 			editor.execCommand(command, false, table);
@@ -101,11 +109,15 @@ export default [
 			tablebincolumn: 'Delete column',
 			tableempty: 'Empty cell'
 		},
-		exec: (editor, table, { control }): void => {
+		exec: (editor, table, { control }): void | false => {
 			if (!isJoditObject(editor)) {
 				return;
 			}
 
+			if (!control.args) {
+				return false;
+			}
+
 			const command = cmd(control);
 
 			editor.execCommand(command, false, table);